[llvm] [Remarks] BitstreamRemarkParser: Refactor error handling (PR #156511)

LLVM Continuous Integration via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 15 07:24:42 PDT 2025 

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `openmp-offload-amdgpu-runtime-2` running on `rocm-worker-hw-02` while building `llvm` at step 5 "compile-openmp".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/10/builds/13493

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (compile-openmp) failure: build (failure)
...
1.579 [3514/64/1153] Building CXX object tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/SemaBPF.cpp.o
1.590 [3513/64/1154] Building CXX object tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/SemaBoundsSafety.cpp.o
1.592 [3512/64/1155] Building CXX object tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/SemaCXXScopeSpec.cpp.o
1.604 [3511/64/1156] Building CXX object tools/clang/lib/Tooling/DependencyScanning/CMakeFiles/obj.clangDependencyScanning.dir/DependencyScanningWorker.cpp.o
1.605 [3510/64/1157] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseCXXInlineMethods.cpp.o
1.608 [3509/64/1158] Building CXX object tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/SemaConsumer.cpp.o
1.610 [3508/64/1159] Building CXX object tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/SemaChecking.cpp.o
1.612 [3507/64/1160] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseDeclCXX.cpp.o
1.627 [3506/64/1161] Building CXX object tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/SemaDirectX.cpp.o
1.652 [3505/64/1162] Building CXX object lib/Remarks/CMakeFiles/LLVMRemarks.dir/RemarkParser.cpp.o
FAILED: lib/Remarks/CMakeFiles/LLVMRemarks.dir/RemarkParser.cpp.o 
ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -DLLVM_EXPORTS -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/lib/Remarks -I/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/llvm/lib/Remarks -I/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/include -I/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -fPIC  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT lib/Remarks/CMakeFiles/LLVMRemarks.dir/RemarkParser.cpp.o -MF lib/Remarks/CMakeFiles/LLVMRemarks.dir/RemarkParser.cpp.o.d -o lib/Remarks/CMakeFiles/LLVMRemarks.dir/RemarkParser.cpp.o -c /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/llvm/lib/Remarks/RemarkParser.cpp
In file included from /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/llvm/lib/Remarks/RemarkParser.cpp:15:
/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/llvm/lib/Remarks/BitstreamRemarkParser.h: In member function ‘llvm::Error llvm::remarks::BitstreamBlockParserHelper<Derived>::parseRecord(unsigned int)’:
/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/llvm/lib/Remarks/BitstreamRemarkParser.h:73:62: error: cannot convert ‘unsigned int’ to ‘llvm::StringRef’
   73 |   Error parseRecord(unsigned Code) { return unexpectedRecord(Code); }
      |                                                              ^~~~
      |                                                              |
      |                                                              unsigned int
/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/llvm/lib/Remarks/BitstreamRemarkParser.h:60:36: note:   initializing argument 1 of ‘llvm::Error llvm::remarks::BitstreamBlockParserHelperBase::unexpectedRecord(llvm::StringRef)’
   60 |   Error unexpectedRecord(StringRef RecordName);
      |                          ~~~~~~~~~~^~~~~~~~~~
1.664 [3505/63/1163] Building CXX object tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/IdentifierResolver.cpp.o
1.690 [3505/62/1164] Building CXX object lib/Remarks/CMakeFiles/LLVMRemarks.dir/BitstreamRemarkParser.cpp.o
FAILED: lib/Remarks/CMakeFiles/LLVMRemarks.dir/BitstreamRemarkParser.cpp.o 
ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -DLLVM_EXPORTS -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/lib/Remarks -I/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/llvm/lib/Remarks -I/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/include -I/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -fPIC  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT lib/Remarks/CMakeFiles/LLVMRemarks.dir/BitstreamRemarkParser.cpp.o -MF lib/Remarks/CMakeFiles/LLVMRemarks.dir/BitstreamRemarkParser.cpp.o.d -o lib/Remarks/CMakeFiles/LLVMRemarks.dir/BitstreamRemarkParser.cpp.o -c /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/llvm/lib/Remarks/BitstreamRemarkParser.cpp
In file included from /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/llvm/lib/Remarks/BitstreamRemarkParser.cpp:14:
/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/llvm/lib/Remarks/BitstreamRemarkParser.h: In member function ‘llvm::Error llvm::remarks::BitstreamBlockParserHelper<Derived>::parseRecord(unsigned int)’:
/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/llvm/lib/Remarks/BitstreamRemarkParser.h:73:62: error: cannot convert ‘unsigned int’ to ‘llvm::StringRef’
   73 |   Error parseRecord(unsigned Code) { return unexpectedRecord(Code); }
      |                                                              ^~~~
      |                                                              |
      |                                                              unsigned int
/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/llvm/lib/Remarks/BitstreamRemarkParser.h:60:36: note:   initializing argument 1 of ‘llvm::Error llvm::remarks::BitstreamBlockParserHelperBase::unexpectedRecord(llvm::StringRef)’
   60 |   Error unexpectedRecord(StringRef RecordName);
      |                          ~~~~~~~~~~^~~~~~~~~~
1.699 [3505/61/1165] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseExpr.cpp.o
1.700 [3505/60/1166] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseAST.cpp.o
1.713 [3505/59/1167] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseHLSLRootSignature.cpp.o
1.715 [3505/58/1168] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseDecl.cpp.o
/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/clang/lib/Parse/ParseDecl.cpp: In member function ‘void clang::Parser::ParseDirectDeclarator(clang::Declarator&)’:
/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/clang/lib/Parse/ParseDecl.cpp:6819:36: warning: enumerated and non-enumerated type in conditional expression [-Wextra]
 6818 |                                 (IsFunctionDeclaration
      |                                  ~~~~~~~~~~~~~~~~~~~~~
 6819 |                                    ? Scope::FunctionDeclarationScope : 0));
      |                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/clang/lib/Parse/ParseDecl.cpp: In member function ‘void clang::Parser::ParseParenDeclarator(clang::Declarator&)’:
/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/clang/lib/Parse/ParseDecl.cpp:7101:32: warning: enumerated and non-enumerated type in conditional expression [-Wextra]
 7100 |                             (D.isFunctionDeclaratorAFunctionDeclaration()

```

</details>

https://github.com/llvm/llvm-project/pull/156511

More information about the llvm-commits mailing list