[llvm] [AMDGPU] expand-fp: unify scalarization (NFC) (PR #158588)

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 15 03:46:00 PDT 2025


================
@@ -356,8 +356,9 @@ Value *FRemExpander::buildFRem(Value *X, Value *Y,
 static bool expandFRem(BinaryOperator &I, std::optional<SimplifyQuery> &SQ) {
   LLVM_DEBUG(dbgs() << "Expanding instruction: " << I << '\n');
 
-  Type *ReturnTy = I.getType();
-  assert(FRemExpander::canExpandType(ReturnTy->getScalarType()));
+  Type *Ty = I.getType();
+  assert(Ty->isFloatingPointTy() && "Instruction should have been scalarized");
+  assert(FRemExpander::canExpandType(Ty));
----------------
arsenm wrote:

Seem like redundant assert conditions, I would expect canExpandType implies isFloatingPointTy 

https://github.com/llvm/llvm-project/pull/158588


More information about the llvm-commits mailing list