[llvm] 8f25ea2 - [NFC] Leave a comment in `Local.cpp` about debug info & sample profiling (#155296)
via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 12 15:05:19 PDT 2025
Author: Mircea Trofin
Date: 2025-09-12T15:05:16-07:00
New Revision: 8f25ea2d73d9a4a64e7ab26e6b1d7a8f73605713
URL: https://github.com/llvm/llvm-project/commit/8f25ea2d73d9a4a64e7ab26e6b1d7a8f73605713
DIFF: https://github.com/llvm/llvm-project/commit/8f25ea2d73d9a4a64e7ab26e6b1d7a8f73605713.diff
LOG: [NFC] Leave a comment in `Local.cpp` about debug info & sample profiling (#155296)
Issue #152767
Added:
Modified:
llvm/lib/Transforms/Utils/Local.cpp
Removed:
################################################################################
diff --git a/llvm/lib/Transforms/Utils/Local.cpp b/llvm/lib/Transforms/Utils/Local.cpp
index 2cfd70a1746c8..57dc1b38b8ec3 100644
--- a/llvm/lib/Transforms/Utils/Local.cpp
+++ b/llvm/lib/Transforms/Utils/Local.cpp
@@ -3342,8 +3342,11 @@ void llvm::hoistAllInstructionsInto(BasicBlock *DomBlock, Instruction *InsertPt,
// retain their original debug locations (DILocations) and debug intrinsic
// instructions.
//
- // Doing so would degrade the debugging experience and adversely affect the
- // accuracy of profiling information.
+ // Doing so would degrade the debugging experience.
+ //
+ // FIXME: Issue #152767: debug info should also be the same as the
+ // original branch, **if** the user explicitly indicated that (for sampling
+ // PGO)
//
// Currently, when hoisting the instructions, we take the following actions:
// - Remove their debug intrinsic instructions.
More information about the llvm-commits
mailing list