[llvm] [PGO][test] Ensure test input is writeable after copying. (PR #158356)
via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 12 13:08:33 PDT 2025
https://github.com/jtstogel created https://github.com/llvm/llvm-project/pull/158356
This test errors when trying to append to the `%t` file when run in an environment where the source tree is mounted read-only, since `cp` preserves the read-only file permission.
>From 9d833cc6ff7335cc04d0ee3201192a165f16139a Mon Sep 17 00:00:00 2001
From: Jackson Stogel <jtstogel at gmail.com>
Date: Fri, 12 Sep 2025 20:05:17 +0000
Subject: [PATCH] [PGO][test] Ensure test input is writeable after copying.
This test errors when trying to append to the `%t` file when run in an environment where the source tree is mounted read-only, since `cp` preserves the read-only file permission.
---
llvm/test/Verifier/llvm.loop.estimated_trip_count.ll | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/llvm/test/Verifier/llvm.loop.estimated_trip_count.ll b/llvm/test/Verifier/llvm.loop.estimated_trip_count.ll
index 3c0bc8a39ebeb..b1e456f5b0ad6 100644
--- a/llvm/test/Verifier/llvm.loop.estimated_trip_count.ll
+++ b/llvm/test/Verifier/llvm.loop.estimated_trip_count.ll
@@ -26,36 +26,43 @@ exit:
; No value.
; RUN: cp %s %t
+; RUN: chmod u+w %t
; RUN: echo '!1 = !{!"llvm.loop.estimated_trip_count"}' >> %t
; RUN: not %{RUN} TOO-FEW
; i16 value.
; RUN: cp %s %t
+; RUN: chmod u+w %t
; RUN: echo '!1 = !{!"llvm.loop.estimated_trip_count", i16 5}' >> %t
; RUN: %{RUN} GOOD
; i32 value.
; RUN: cp %s %t
+; RUN: chmod u+w %t
; RUN: echo '!1 = !{!"llvm.loop.estimated_trip_count", i32 5}' >> %t
; RUN: %{RUN} GOOD
; i64 value.
; RUN: cp %s %t
+; RUN: chmod u+w %t
; RUN: echo '!1 = !{!"llvm.loop.estimated_trip_count", i64 5}' >> %t
; RUN: not %{RUN} BAD-VALUE
; MDString value.
; RUN: cp %s %t
+; RUN: chmod u+w %t
; RUN: echo '!1 = !{!"llvm.loop.estimated_trip_count", !"5"}' >> %t
; RUN: not %{RUN} BAD-VALUE
; MDNode value.
; RUN: cp %s %t
+; RUN: chmod u+w %t
; RUN: echo '!1 = !{!"llvm.loop.estimated_trip_count", !2}' >> %t
; RUN: echo '!2 = !{i32 5}' >> %t
; RUN: not %{RUN} BAD-VALUE
; Too many values.
; RUN: cp %s %t
+; RUN: chmod u+w %t
; RUN: echo '!1 = !{!"llvm.loop.estimated_trip_count", i32 5, i32 5}' >> %t
; RUN: not %{RUN} TOO-MANY
More information about the llvm-commits
mailing list