[llvm] [CoroSplit] AllocaUseVisitor visits insertvalue/insertelement (PR #156788)

[Weibo He via llvm-commits]

NewSigma wrote:

> I'm not familiar with AllocaUseVisitor and handleAlias(), but how do we know that we're not missing other visit functions?

All `visit` functions will call `visitInstruction` of `InstVisitor` by default. I scaned the code and I think we have handled all paths to `visitInstruction`. We can add an assertion to `visitInstruction` if further validation is desired.

> > It's not clear to me what criteria is used to decide which instructions need a visit function and call to handleAlias(), and which do not.
>
> It is basically an escape analysis.


> For example, I noticed that visitPtrToIntInst() isn't implemented.

No, it is handled by `PtrUseVisitor`, the base class of `AllocaUseVisitor`.


https://github.com/llvm/llvm-project/pull/156788