[lld] [llvm] [lld][MachO] Follow-up to use madvise() for threaded file page-in. (PR #157917)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 12 00:54:45 PDT 2025


================
@@ -584,7 +584,8 @@ Expected<StringRef> Archive::Child::getBuffer() const {
   if (!FullNameOrErr)
     return FullNameOrErr.takeError();
   const std::string &FullName = *FullNameOrErr;
-  ErrorOr<std::unique_ptr<MemoryBuffer>> Buf = MemoryBuffer::getFile(FullName);
+  ErrorOr<std::unique_ptr<MemoryBuffer>> Buf =
+      MemoryBuffer::getFile(FullName, false, /*RequiresNullTerminator*/ false);
----------------
jh7370 wrote:

```suggestion
      MemoryBuffer::getFile(FullName, false, /*RequiresNullTerminator=*/false);
```
This is the correct format.

https://github.com/llvm/llvm-project/pull/157917


More information about the llvm-commits mailing list