[llvm] [llvm] Move data layout string computation to TargetParser (PR #157612)

Thu Sep 11 15:53:24 PDT 2025

mshockwave wrote:

> LLVM Buildbot has detected a new failure on builder `clang-ppc64le-rhel` running on `ppc64le-clang-rhel-test` while building `llvm` at step 5 "build-unified-tree".
> 
> Full details are available at: https://lab.llvm.org/buildbot/#/builders/145/builds/9706
> 
> Here is the relevant piece of the build log for the reference
> ```
> Step 5 (build-unified-tree) failure: build (failure)
> ...
> 416.063 [2243/192/4216] Creating library symlink lib/libLLVMInterpreter.so
> 416.071 [2242/192/4217] Creating library symlink lib/libLLVMAVRCodeGen.so
> 416.077 [2241/192/4218] Linking CXX shared library lib/libLLVMDWARFLinkerClassic.so.22.0git
> 416.080 [2240/192/4219] Creating library symlink lib/libLLVMDWARFLinkerParallel.so
> 416.096 [2239/192/4220] Linking CXX shared library lib/libLLVMLanaiCodeGen.so.22.0git
> 416.102 [2238/192/4221] Creating library symlink lib/libLLVMDWARFLinkerClassic.so
> 416.116 [2237/192/4222] Creating library symlink lib/libLLVMLanaiCodeGen.so
> 416.122 [2236/192/4223] Linking CXX shared library lib/libLLVMLoongArchCodeGen.so.22.0git
> 416.158 [2235/192/4224] Creating library symlink lib/libLLVMLoongArchCodeGen.so
> 416.266 [2234/192/4225] Linking CXX shared library lib/libLLVMMSP430CodeGen.so.22.0git
> FAILED: lib/libLLVMMSP430CodeGen.so.22.0git 
> : && /home/buildbots/llvm-external-buildbots/clang.19.1.7/bin/clang++ --gcc-toolchain=/gcc-toolchain/usr -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete -Wl,--color-diagnostics   -Wl,--gc-sections  -Xlinker --dependency-file=lib/Target/MSP430/CMakeFiles/LLVMMSP430CodeGen.dir/link.d -shared -Wl,-soname,libLLVMMSP430CodeGen.so.22.0git -o lib/libLLVMMSP430CodeGen.so.22.0git lib/Target/MSP430/CMakeFiles/LLVMMSP430CodeGen.dir/MSP430BranchSelector.cpp.o lib/Target/MSP430/CMakeFiles/LLVMMSP430CodeGen.dir/MSP430ISelDAGToDAG.cpp.o lib/Target/MSP430/CMakeFiles/LLVMMSP430CodeGen.dir/MSP430ISelLowering.cpp.o lib/Target/MSP430/CMakeFiles/LLVMMSP430CodeGen.dir/MSP430InstrInfo.cpp.o lib/Target/MSP430/CMakeFiles/LLVMMSP430CodeGen.dir/MSP430FrameLowering.cpp.o lib/Target/MSP430/CMakeFiles/LLVMMSP430CodeGen.dir/MSP430MachineFunctionInfo.cpp.o lib/Target/MSP430/CMakeFiles/LLVMMSP430CodeGen.dir/MSP430RegisterInfo.cpp.o lib/Target/MSP430/CMakeFiles/LLVMMSP430CodeGen.dir/MSP430SelectionDAGInfo.cpp.o lib/Target/MSP430/CMakeFiles/LLVMMSP430CodeGen.dir/MSP430Subtarget.cpp.o lib/Target/MSP430/CMakeFiles/LLVMMSP430CodeGen.dir/MSP430TargetMachine.cpp.o lib/Target/MSP430/CMakeFiles/LLVMMSP430CodeGen.dir/MSP430AsmPrinter.cpp.o lib/Target/MSP430/CMakeFiles/LLVMMSP430CodeGen.dir/MSP430MCInstLower.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/build/lib:"  lib/libLLVMAsmPrinter.so.22.0git  lib/libLLVMMSP430Desc.so.22.0git  lib/libLLVMMSP430Info.so.22.0git  lib/libLLVMSelectionDAG.so.22.0git  lib/libLLVMCodeGen.so.22.0git  lib/libLLVMCodeGenTypes.so.22.0git  lib/libLLVMTarget.so.22.0git  lib/libLLVMMC.so.22.0git  lib/libLLVMCore.so.22.0git  lib/libLLVMSupport.so.22.0git  -Wl,-rpath-link,/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/build/lib && :
> ld.lld: error: undefined symbol: llvm::Triple::computeDataLayout[abi:cxx11](llvm::StringRef) const
> >>> referenced by MSP430TargetMachine.cpp
> >>>               lib/Target/MSP430/CMakeFiles/LLVMMSP430CodeGen.dir/MSP430TargetMachine.cpp.o:(llvm::MSP430TargetMachine::MSP430TargetMachine(llvm::Target const&, llvm::Triple const&, llvm::StringRef, llvm::StringRef, llvm::TargetOptions const&, std::optional<llvm::Reloc::Model>, std::optional<llvm::CodeModel::Model>, llvm::CodeGenOptLevel, bool))
> clang++: error: linker command failed with exit code 1 (use -v to see invocation)
> 416.289 [2234/191/4226] Linking CXX shared library lib/libLLVMSparcCodeGen.so.22.0git
> 416.328 [2234/190/4227] Linking CXX shared library lib/libLLVMMipsCodeGen.so.22.0git
> 416.372 [2234/189/4228] Linking CXX shared library lib/libLLVMPowerPCCodeGen.so.22.0git
> 416.376 [2234/188/4229] Linking CXX shared library lib/libLLVMSystemZCodeGen.so.22.0git
> 416.382 [2234/187/4230] Linking CXX shared library lib/libLLVMSPIRVCodeGen.so.22.0git
> 416.934 [2234/186/4231] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseDeclCXX.cpp.o
> 417.127 [2234/185/4232] Building CXX object tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/SemaNVPTX.cpp.o
> 417.473 [2234/184/4233] Building CXX object tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/ABIInfoImpl.cpp.o
> 417.986 [2234/183/4234] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParsePragma.cpp.o
> 418.053 [2234/182/4235] Building CXX object lib/Target/RISCV/CMakeFiles/LLVMRISCVCodeGen.dir/RISCVISelLowering.cpp.o
> 418.100 [2234/181/4236] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseOpenMP.cpp.o
> 418.263 [2234/180/4237] Building CXX object tools/clang/lib/CrossTU/CMakeFiles/obj.clangCrossTU.dir/CrossTranslationUnit.cpp.o
> 418.372 [2234/179/4238] Building CXX object tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/SemaMIPS.cpp.o
> 418.429 [2234/178/4239] Building CXX object tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/JumpDiagnostics.cpp.o
> 418.849 [2234/177/4240] Building CXX object tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/SemaAccess.cpp.o
> 419.411 [2234/176/4241] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/ByteCode/ByteCodeEmitter.cpp.o
> 420.146 [2234/175/4242] Building CXX object tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/SemaSystemZ.cpp.o
> 420.333 [2234/174/4243] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/Type.cpp.o
> 420.598 [2234/173/4244] Building CXX object tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/SemaFixItUtils.cpp.o
> 421.965 [2234/172/4245] Building CXX object tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/CGAtomic.cpp.o
> 422.119 [2234/171/4246] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/MicrosoftMangle.cpp.o
> 422.391 [2234/170/4247] Building CXX object tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/SemaSPIRV.cpp.o
> 422.464 [2234/169/4248] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/Expr.cpp.o
> 422.556 [2234/168/4249] Building CXX object tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/SemaPPC.cpp.o
> 422.790 [2234/167/4250] Building CXX object tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/SemaOpenCL.cpp.o
> 423.184 [2234/166/4251] Building CXX object tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/SemaCXXScopeSpec.cpp.o
> 424.770 [2234/165/4252] Building CXX object tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/SemaWasm.cpp.o
> 424.774 [2234/164/4253] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/StmtPrinter.cpp.o
> 424.806 [2234/163/4254] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseDecl.cpp.o
> 424.847 [2234/162/4255] Building CXX object tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/CGLoopInfo.cpp.o
> 424.988 [2234/161/4256] Building CXX object tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/SemaSwift.cpp.o
> 425.501 [2234/160/4257] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/JSONNodeDumper.cpp.o
> 426.503 [2234/159/4258] Building CXX object tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/SemaOpenACCClause.cpp.o
> ```

This is probably caused by the fact that `TargetParser` is missing from MSP430CodeGen's link components.

https://github.com/llvm/llvm-project/pull/157612