[llvm] [mlir] [LLVM][MLIR] Move LSP server support library from MLIR into LLVM (PR #157885)

Thu Sep 11 10:58:26 PDT 2025

Albert =?utf-8?q?Havliček?= <ahavlicek at azul.com>,
Albert =?utf-8?q?Havliček?= <ahavlicek at azul.com>,
Albert =?utf-8?q?Havliček?= <ahavlicek at azul.com>,
Albert =?utf-8?q?Havliček?= <ahavlicek at azul.com>,
Albert =?utf-8?q?Havliček?= <ahavlicek at azul.com>,
Albert =?utf-8?q?Havliček?= <ahavlicek at azul.com>,
Albert =?utf-8?q?Havliček?= <ahavlicek at azul.com>,
Albert =?utf-8?q?Havliček?= <ahavlicek at azul.com>,
Albert =?utf-8?q?Havliček?= <ahavlicek at azul.com>,
Albert =?utf-8?q?Havliček?= <ahavlicek at azul.com>,
Albert =?utf-8?q?Havliček?= <ahavlicek at azul.com>,
Albert =?utf-8?q?Havliček?= <ahavlicek at azul.com>,
Albert =?utf-8?q?Havliček?= <ahavlicek at azul.com>,
Albert =?utf-8?q?Havliček?= <ahavlicek at azul.com>,
Albert =?utf-8?q?Havliček?= <ahavlicek at azul.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/157885 at github.com>

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `amdgpu-offload-rhel-8-cmake-build-only` running on `rocm-docker-rhel-8` while building `llvm,mlir` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/204/builds/21763

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (annotate) failure: '../llvm-zorg/zorg/buildbot/builders/annotated/amdgpu-offload-cmake.py --jobs=32' (failure)
...
[1231/8063] Building CXX object lib/Support/LSP/CMakeFiles/LLVMSupportLSP.dir/Transport.cpp.o
[1232/8063] Building SPIRVGenInstrInfo.inc...
[1233/8063] Building R600GenDAGISel.inc...
[1234/8063] Building SPIRVGenSubtargetInfo.inc...
[1235/8063] Building SPIRVGenRegisterInfo.inc...
[1236/8063] Building CXX object tools/flang/lib/Decimal/CMakeFiles/FortranDecimal.dir/binary-to-decimal.cpp.o
[1237/8063] Building CXX object lib/Support/LSP/CMakeFiles/LLVMSupportLSP.dir/Protocol.cpp.o
[1238/8063] Building RISCVTargetParserDef.inc...
[1239/8063] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/AbstractCallSite.cpp.o
[1240/8063] Linking CXX shared library lib/libLLVMSupportLSP.so.22.0git
FAILED: lib/libLLVMSupportLSP.so.22.0git 
: && /usr/bin/c++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/./lib  -Wl,--gc-sections -shared -Wl,-soname,libLLVMSupportLSP.so.22.0git -o lib/libLLVMSupportLSP.so.22.0git lib/Support/LSP/CMakeFiles/LLVMSupportLSP.dir/Protocol.cpp.o lib/Support/LSP/CMakeFiles/LLVMSupportLSP.dir/Transport.cpp.o lib/Support/LSP/CMakeFiles/LLVMSupportLSP.dir/Logging.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:" && :
lib/Support/LSP/CMakeFiles/LLVMSupportLSP.dir/Protocol.cpp.o: In function `llvm::StringSet<llvm::MallocAllocator>::~StringSet()':
Protocol.cpp:(.text._ZN4llvm9StringSetINS_15MallocAllocatorEED2Ev[_ZN4llvm9StringSetINS_15MallocAllocatorEED5Ev]+0x3b): undefined reference to `llvm::deallocate_buffer(void*, unsigned long, unsigned long)'
lib/Support/LSP/CMakeFiles/LLVMSupportLSP.dir/Protocol.cpp.o: In function `llvm::raw_ostream::operator<<(char const*)':
Protocol.cpp:(.text._ZN4llvm11raw_ostreamlsEPKc[_ZN4llvm11raw_ostreamlsEPKc]+0x38): undefined reference to `llvm::raw_ostream::write(char const*, unsigned long)'
lib/Support/LSP/CMakeFiles/LLVMSupportLSP.dir/Protocol.cpp.o: In function `llvm::Error::~Error()':
Protocol.cpp:(.text._ZN4llvm5ErrorD2Ev[_ZN4llvm5ErrorD5Ev]+0x15): undefined reference to `llvm::Error::fatalUncheckedError() const'
lib/Support/LSP/CMakeFiles/LLVMSupportLSP.dir/Protocol.cpp.o: In function `llvm::json::Value::Value(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >)':
Protocol.cpp:(.text._ZN4llvm4json5ValueC2ENSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE[_ZN4llvm4json5ValueC5ENSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE]+0x1e): undefined reference to `llvm::json::isUTF8(llvm::StringRef, unsigned long*)'
lib/Support/LSP/CMakeFiles/LLVMSupportLSP.dir/Protocol.cpp.o: In function `llvm::json::ObjectKey::ObjectKey(char const*)':
Protocol.cpp:(.text._ZN4llvm4json9ObjectKeyC2EPKc[_ZN4llvm4json9ObjectKeyC5EPKc]+0x34): undefined reference to `llvm::json::isUTF8(llvm::StringRef, unsigned long*)'
lib/Support/LSP/CMakeFiles/LLVMSupportLSP.dir/Protocol.cpp.o: In function `llvm::json::ObjectKey::ObjectKey(llvm::StringRef)':
Protocol.cpp:(.text._ZN4llvm4json9ObjectKeyC2ENS_9StringRefE[_ZN4llvm4json9ObjectKeyC5ENS_9StringRefE]+0x1f): undefined reference to `llvm::json::isUTF8(llvm::StringRef, unsigned long*)'
lib/Support/LSP/CMakeFiles/LLVMSupportLSP.dir/Protocol.cpp.o: In function `llvm::lsp::URIForFile::scheme() const':
Protocol.cpp:(.text._ZNK4llvm3lsp10URIForFile6schemeEv+0x2d): undefined reference to `llvm::StringRef::find(llvm::StringRef, unsigned long) const'
lib/Support/LSP/CMakeFiles/LLVMSupportLSP.dir/Protocol.cpp.o: In function `llvm::lsp::toJSON(llvm::lsp::URIForFile const&)':
Protocol.cpp:(.text._ZN4llvm3lsp6toJSONERKNS0_10URIForFileE+0x1f): undefined reference to `llvm::json::isUTF8(llvm::StringRef, unsigned long*)'
lib/Support/LSP/CMakeFiles/LLVMSupportLSP.dir/Protocol.cpp.o: In function `llvm::lsp::operator<<(llvm::raw_ostream&, llvm::lsp::URIForFile const&)':
Protocol.cpp:(.text._ZN4llvm3lsplsERNS_11raw_ostreamERKNS0_10URIForFileE+0x5d): undefined reference to `llvm::raw_ostream::write(char const*, unsigned long)'
lib/Support/LSP/CMakeFiles/LLVMSupportLSP.dir/Protocol.cpp.o: In function `llvm::lsp::fromJSON(llvm::json::Value const&, llvm::lsp::ClientCapabilities&, llvm::json::Path) [clone .localalias.34]':
Protocol.cpp:(.text._ZN4llvm3lsp8fromJSONERKNS_4json5ValueERNS0_18ClientCapabilitiesENS1_4PathE+0x35): undefined reference to `llvm::json::Object::getObject(llvm::StringRef) const'
Protocol.cpp:(.text._ZN4llvm3lsp8fromJSONERKNS_4json5ValueERNS0_18ClientCapabilitiesENS1_4PathE+0x5f): undefined reference to `llvm::json::Object::getObject(llvm::StringRef) const'
Protocol.cpp:(.text._ZN4llvm3lsp8fromJSONERKNS_4json5ValueERNS0_18ClientCapabilitiesENS1_4PathE+0x85): undefined reference to `llvm::json::Object::getBoolean(llvm::StringRef) const'
Protocol.cpp:(.text._ZN4llvm3lsp8fromJSONERKNS_4json5ValueERNS0_18ClientCapabilitiesENS1_4PathE+0xaf): undefined reference to `llvm::json::Object::getObject(llvm::StringRef) const'
Protocol.cpp:(.text._ZN4llvm3lsp8fromJSONERKNS_4json5ValueERNS0_18ClientCapabilitiesENS1_4PathE+0xd5): undefined reference to `llvm::json::Object::getObject(llvm::StringRef) const'
Protocol.cpp:(.text._ZN4llvm3lsp8fromJSONERKNS_4json5ValueERNS0_18ClientCapabilitiesENS1_4PathE+0xfe): undefined reference to `llvm::json::Object::getObject(llvm::StringRef) const'
Protocol.cpp:(.text._ZN4llvm3lsp8fromJSONERKNS_4json5ValueERNS0_18ClientCapabilitiesENS1_4PathE+0x129): undefined reference to `llvm::json::Object::getBoolean(llvm::StringRef) const'
Protocol.cpp:(.text._ZN4llvm3lsp8fromJSONERKNS_4json5ValueERNS0_18ClientCapabilitiesENS1_4PathE+0x172): undefined reference to `llvm::json::Path::report(llvm::StringLiteral)'
lib/Support/LSP/CMakeFiles/LLVMSupportLSP.dir/Protocol.cpp.o: In function `llvm::lsp::fromJSON(llvm::json::Value const&, llvm::lsp::Position&, llvm::json::Path) [clone .localalias.28]':
Protocol.cpp:(.text._ZN4llvm3lsp8fromJSONERKNS_4json5ValueERNS0_8PositionENS1_4PathE+0x4c): undefined reference to `llvm::json::Object::get(llvm::StringRef) const'
Protocol.cpp:(.text._ZN4llvm3lsp8fromJSONERKNS_4json5ValueERNS0_8PositionENS1_4PathE+0x9e): undefined reference to `llvm::json::Object::get(llvm::StringRef) const'
Protocol.cpp:(.text._ZN4llvm3lsp8fromJSONERKNS_4json5ValueERNS0_8PositionENS1_4PathE+0xe0): undefined reference to `llvm::json::Path::report(llvm::StringLiteral)'
Protocol.cpp:(.text._ZN4llvm3lsp8fromJSONERKNS_4json5ValueERNS0_8PositionENS1_4PathE+0x113): undefined reference to `llvm::json::Path::report(llvm::StringLiteral)'
Protocol.cpp:(.text._ZN4llvm3lsp8fromJSONERKNS_4json5ValueERNS0_8PositionENS1_4PathE+0x160): undefined reference to `llvm::json::Path::report(llvm::StringLiteral)'
lib/Support/LSP/CMakeFiles/LLVMSupportLSP.dir/Protocol.cpp.o: In function `llvm::lsp::operator<<(llvm::raw_ostream&, llvm::lsp::Position const&)':
Protocol.cpp:(.text._ZN4llvm3lsplsERNS_11raw_ostreamERKNS0_8PositionE+0x8): undefined reference to `llvm::raw_ostream::operator<<(long)'
Protocol.cpp:(.text._ZN4llvm3lsplsERNS_11raw_ostreamERKNS0_8PositionE+0x39): undefined reference to `llvm::raw_ostream::write(unsigned char)'
Protocol.cpp:(.text._ZN4llvm3lsplsERNS_11raw_ostreamERKNS0_8PositionE+0x2a): undefined reference to `llvm::raw_ostream::operator<<(long)'
Step 7 (build cmake config) failure: build cmake config (failure)
...
[1231/8063] Building CXX object lib/Support/LSP/CMakeFiles/LLVMSupportLSP.dir/Transport.cpp.o
[1232/8063] Building SPIRVGenInstrInfo.inc...
[1233/8063] Building R600GenDAGISel.inc...
[1234/8063] Building SPIRVGenSubtargetInfo.inc...
[1235/8063] Building SPIRVGenRegisterInfo.inc...
[1236/8063] Building CXX object tools/flang/lib/Decimal/CMakeFiles/FortranDecimal.dir/binary-to-decimal.cpp.o
[1237/8063] Building CXX object lib/Support/LSP/CMakeFiles/LLVMSupportLSP.dir/Protocol.cpp.o
[1238/8063] Building RISCVTargetParserDef.inc...
[1239/8063] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/AbstractCallSite.cpp.o
[1240/8063] Linking CXX shared library lib/libLLVMSupportLSP.so.22.0git
FAILED: lib/libLLVMSupportLSP.so.22.0git 
: && /usr/bin/c++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/./lib  -Wl,--gc-sections -shared -Wl,-soname,libLLVMSupportLSP.so.22.0git -o lib/libLLVMSupportLSP.so.22.0git lib/Support/LSP/CMakeFiles/LLVMSupportLSP.dir/Protocol.cpp.o lib/Support/LSP/CMakeFiles/LLVMSupportLSP.dir/Transport.cpp.o lib/Support/LSP/CMakeFiles/LLVMSupportLSP.dir/Logging.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:" && :
lib/Support/LSP/CMakeFiles/LLVMSupportLSP.dir/Protocol.cpp.o: In function `llvm::StringSet<llvm::MallocAllocator>::~StringSet()':
Protocol.cpp:(.text._ZN4llvm9StringSetINS_15MallocAllocatorEED2Ev[_ZN4llvm9StringSetINS_15MallocAllocatorEED5Ev]+0x3b): undefined reference to `llvm::deallocate_buffer(void*, unsigned long, unsigned long)'
lib/Support/LSP/CMakeFiles/LLVMSupportLSP.dir/Protocol.cpp.o: In function `llvm::raw_ostream::operator<<(char const*)':
Protocol.cpp:(.text._ZN4llvm11raw_ostreamlsEPKc[_ZN4llvm11raw_ostreamlsEPKc]+0x38): undefined reference to `llvm::raw_ostream::write(char const*, unsigned long)'
lib/Support/LSP/CMakeFiles/LLVMSupportLSP.dir/Protocol.cpp.o: In function `llvm::Error::~Error()':
Protocol.cpp:(.text._ZN4llvm5ErrorD2Ev[_ZN4llvm5ErrorD5Ev]+0x15): undefined reference to `llvm::Error::fatalUncheckedError() const'
lib/Support/LSP/CMakeFiles/LLVMSupportLSP.dir/Protocol.cpp.o: In function `llvm::json::Value::Value(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >)':
Protocol.cpp:(.text._ZN4llvm4json5ValueC2ENSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE[_ZN4llvm4json5ValueC5ENSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE]+0x1e): undefined reference to `llvm::json::isUTF8(llvm::StringRef, unsigned long*)'
lib/Support/LSP/CMakeFiles/LLVMSupportLSP.dir/Protocol.cpp.o: In function `llvm::json::ObjectKey::ObjectKey(char const*)':
Protocol.cpp:(.text._ZN4llvm4json9ObjectKeyC2EPKc[_ZN4llvm4json9ObjectKeyC5EPKc]+0x34): undefined reference to `llvm::json::isUTF8(llvm::StringRef, unsigned long*)'
lib/Support/LSP/CMakeFiles/LLVMSupportLSP.dir/Protocol.cpp.o: In function `llvm::json::ObjectKey::ObjectKey(llvm::StringRef)':
Protocol.cpp:(.text._ZN4llvm4json9ObjectKeyC2ENS_9StringRefE[_ZN4llvm4json9ObjectKeyC5ENS_9StringRefE]+0x1f): undefined reference to `llvm::json::isUTF8(llvm::StringRef, unsigned long*)'
lib/Support/LSP/CMakeFiles/LLVMSupportLSP.dir/Protocol.cpp.o: In function `llvm::lsp::URIForFile::scheme() const':
Protocol.cpp:(.text._ZNK4llvm3lsp10URIForFile6schemeEv+0x2d): undefined reference to `llvm::StringRef::find(llvm::StringRef, unsigned long) const'
lib/Support/LSP/CMakeFiles/LLVMSupportLSP.dir/Protocol.cpp.o: In function `llvm::lsp::toJSON(llvm::lsp::URIForFile const&)':
Protocol.cpp:(.text._ZN4llvm3lsp6toJSONERKNS0_10URIForFileE+0x1f): undefined reference to `llvm::json::isUTF8(llvm::StringRef, unsigned long*)'
lib/Support/LSP/CMakeFiles/LLVMSupportLSP.dir/Protocol.cpp.o: In function `llvm::lsp::operator<<(llvm::raw_ostream&, llvm::lsp::URIForFile const&)':
Protocol.cpp:(.text._ZN4llvm3lsplsERNS_11raw_ostreamERKNS0_10URIForFileE+0x5d): undefined reference to `llvm::raw_ostream::write(char const*, unsigned long)'
lib/Support/LSP/CMakeFiles/LLVMSupportLSP.dir/Protocol.cpp.o: In function `llvm::lsp::fromJSON(llvm::json::Value const&, llvm::lsp::ClientCapabilities&, llvm::json::Path) [clone .localalias.34]':
Protocol.cpp:(.text._ZN4llvm3lsp8fromJSONERKNS_4json5ValueERNS0_18ClientCapabilitiesENS1_4PathE+0x35): undefined reference to `llvm::json::Object::getObject(llvm::StringRef) const'
Protocol.cpp:(.text._ZN4llvm3lsp8fromJSONERKNS_4json5ValueERNS0_18ClientCapabilitiesENS1_4PathE+0x5f): undefined reference to `llvm::json::Object::getObject(llvm::StringRef) const'
Protocol.cpp:(.text._ZN4llvm3lsp8fromJSONERKNS_4json5ValueERNS0_18ClientCapabilitiesENS1_4PathE+0x85): undefined reference to `llvm::json::Object::getBoolean(llvm::StringRef) const'
Protocol.cpp:(.text._ZN4llvm3lsp8fromJSONERKNS_4json5ValueERNS0_18ClientCapabilitiesENS1_4PathE+0xaf): undefined reference to `llvm::json::Object::getObject(llvm::StringRef) const'
Protocol.cpp:(.text._ZN4llvm3lsp8fromJSONERKNS_4json5ValueERNS0_18ClientCapabilitiesENS1_4PathE+0xd5): undefined reference to `llvm::json::Object::getObject(llvm::StringRef) const'
Protocol.cpp:(.text._ZN4llvm3lsp8fromJSONERKNS_4json5ValueERNS0_18ClientCapabilitiesENS1_4PathE+0xfe): undefined reference to `llvm::json::Object::getObject(llvm::StringRef) const'
Protocol.cpp:(.text._ZN4llvm3lsp8fromJSONERKNS_4json5ValueERNS0_18ClientCapabilitiesENS1_4PathE+0x129): undefined reference to `llvm::json::Object::getBoolean(llvm::StringRef) const'
Protocol.cpp:(.text._ZN4llvm3lsp8fromJSONERKNS_4json5ValueERNS0_18ClientCapabilitiesENS1_4PathE+0x172): undefined reference to `llvm::json::Path::report(llvm::StringLiteral)'
lib/Support/LSP/CMakeFiles/LLVMSupportLSP.dir/Protocol.cpp.o: In function `llvm::lsp::fromJSON(llvm::json::Value const&, llvm::lsp::Position&, llvm::json::Path) [clone .localalias.28]':
Protocol.cpp:(.text._ZN4llvm3lsp8fromJSONERKNS_4json5ValueERNS0_8PositionENS1_4PathE+0x4c): undefined reference to `llvm::json::Object::get(llvm::StringRef) const'
Protocol.cpp:(.text._ZN4llvm3lsp8fromJSONERKNS_4json5ValueERNS0_8PositionENS1_4PathE+0x9e): undefined reference to `llvm::json::Object::get(llvm::StringRef) const'
Protocol.cpp:(.text._ZN4llvm3lsp8fromJSONERKNS_4json5ValueERNS0_8PositionENS1_4PathE+0xe0): undefined reference to `llvm::json::Path::report(llvm::StringLiteral)'
Protocol.cpp:(.text._ZN4llvm3lsp8fromJSONERKNS_4json5ValueERNS0_8PositionENS1_4PathE+0x113): undefined reference to `llvm::json::Path::report(llvm::StringLiteral)'
Protocol.cpp:(.text._ZN4llvm3lsp8fromJSONERKNS_4json5ValueERNS0_8PositionENS1_4PathE+0x160): undefined reference to `llvm::json::Path::report(llvm::StringLiteral)'
lib/Support/LSP/CMakeFiles/LLVMSupportLSP.dir/Protocol.cpp.o: In function `llvm::lsp::operator<<(llvm::raw_ostream&, llvm::lsp::Position const&)':
Protocol.cpp:(.text._ZN4llvm3lsplsERNS_11raw_ostreamERKNS0_8PositionE+0x8): undefined reference to `llvm::raw_ostream::operator<<(long)'
Protocol.cpp:(.text._ZN4llvm3lsplsERNS_11raw_ostreamERKNS0_8PositionE+0x39): undefined reference to `llvm::raw_ostream::write(unsigned char)'
Protocol.cpp:(.text._ZN4llvm3lsplsERNS_11raw_ostreamERKNS0_8PositionE+0x2a): undefined reference to `llvm::raw_ostream::operator<<(long)'

```

</details>

https://github.com/llvm/llvm-project/pull/157885