[llvm] [AArch64][SME] Refactor MachineSMEABI pass state (NFCI) (PR #156674)

Gaƫtan Bossu via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 11 05:17:30 PDT 2025


================
@@ -192,25 +248,28 @@ struct MachineSMEABI : public MachineFunctionPass {
 
   /// Collects the needed ZA state (and live registers) before each instruction
   /// within the machine function.
-  void collectNeededZAStates(SMEAttrs);
+  FunctionInfo collectNeededZAStates(SMEAttrs SMEFnAttrs);
 
   /// Assigns each edge bundle a ZA state based on the needed states of blocks
   /// that have incoming or outgoing edges in that bundle.
-  void assignBundleZAStates();
+  SmallVector<ZAState> assignBundleZAStates(EdgeBundles const &Bundles,
+                                            FunctionInfo const &FnInfo);
----------------
gbossu wrote:

Super-Nit: I feel the unwritten convention in LLVM is to write `const` on the left, i.e. `const EdgeBundles &Bundles`. And I also find it less ambiguous because the `const` is definitely attached to `EdgeBundles`, not `&`. That and you can read left-to-right. But oh well, I feel I'm preaching for a church now :)

https://github.com/llvm/llvm-project/pull/156674


More information about the llvm-commits mailing list