[llvm] [LTO] Fix the issue of setting default triple when the triple is empty. (PR #157829)

Feng Zou via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 10 08:03:12 PDT 2025


https://github.com/fzou1 updated https://github.com/llvm/llvm-project/pull/157829

>From 274148811a2b600c1ca4414bea4f1693bdc11b08 Mon Sep 17 00:00:00 2001
From: Feng Zou <feng.zou at intel.com>
Date: Wed, 10 Sep 2025 18:39:39 +0800
Subject: [PATCH 1/2] [LTO] Fix the issue of setting default triple when the
 triple is empty.

---
 llvm/lib/LTO/LTOCodeGenerator.cpp | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/llvm/lib/LTO/LTOCodeGenerator.cpp b/llvm/lib/LTO/LTOCodeGenerator.cpp
index cdeab98ff6c98..8ea4e530dc3eb 100644
--- a/llvm/lib/LTO/LTOCodeGenerator.cpp
+++ b/llvm/lib/LTO/LTOCodeGenerator.cpp
@@ -377,8 +377,9 @@ bool LTOCodeGenerator::determineTarget() {
 
   TripleStr = MergedModule->getTargetTriple().str();
   llvm::Triple Triple(TripleStr);
-  if (TripleStr.empty()) {
-    TripleStr = sys::getDefaultTargetTriple();
+  if (Triple.empty()) {
+    Triple = llvm::Triple(sys::getDefaultTargetTriple());
+    TripleStr = Triple.getTriple();
     MergedModule->setTargetTriple(Triple);
   }
 

>From 5b4918515d2e111c171cab738e253376521c4dfa Mon Sep 17 00:00:00 2001
From: Feng Zou <feng.zou at intel.com>
Date: Wed, 10 Sep 2025 23:02:33 +0800
Subject: [PATCH 2/2] Add test

---
 llvm/test/LTO/X86/empty-triple.ll | 7 +++++++
 1 file changed, 7 insertions(+)
 create mode 100644 llvm/test/LTO/X86/empty-triple.ll

diff --git a/llvm/test/LTO/X86/empty-triple.ll b/llvm/test/LTO/X86/empty-triple.ll
new file mode 100644
index 0000000000000..200d7121f69d6
--- /dev/null
+++ b/llvm/test/LTO/X86/empty-triple.ll
@@ -0,0 +1,7 @@
+; RUN: llvm-as < %s >%t1
+; RUN: llvm-lto -o %t2 %t1  2>&1 | FileCheck --allow-empty %s
+
+; The test is to check the triple is set to default one when it's empty.
+; Otherwise, an error will be raised by llvm-lto.
+
+; CHECK-NOT: llvm-lto: error: No available targets are compatible with triple ""



More information about the llvm-commits mailing list