[compiler-rt] 4b55593 - [compiler-rt] Fix a bug introduced into DEFINE_COMPILERRT_FUNCTION_ALIAS (#156979)

via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 9 13:17:20 PDT 2025


Author: Jon Roelofs
Date: 2025-09-09T14:17:17-06:00
New Revision: 4b5559348bb5c318f131e13bcd32630667de4cce

URL: https://github.com/llvm/llvm-project/commit/4b5559348bb5c318f131e13bcd32630667de4cce
DIFF: https://github.com/llvm/llvm-project/commit/4b5559348bb5c318f131e13bcd32630667de4cce.diff

LOG: [compiler-rt] Fix a bug introduced into DEFINE_COMPILERRT_FUNCTION_ALIAS (#156979)

... during a refactoring for arm64ec in #137960
6ade80ce18087b1e27505985a254c487679e16b8. The subtle change here results
in a change in symbols in the library from:

```
  00000038 T ___gesf2
  00000038 T ___gtsf2
```

to:

```
           I ___gesf2 (indirect for __gtsf2)
  00000038 T ___gtsf2
```

... which is a breaking change on Mach-O platforms.

rdar://157846316

Added: 
    

Modified: 
    compiler-rt/lib/builtins/assembly.h

Removed: 
    


################################################################################
diff  --git a/compiler-rt/lib/builtins/assembly.h b/compiler-rt/lib/builtins/assembly.h
index d7db7d8189457..d1e532813aa24 100644
--- a/compiler-rt/lib/builtins/assembly.h
+++ b/compiler-rt/lib/builtins/assembly.h
@@ -304,7 +304,7 @@
   .globl FUNC_SYMBOL(SYMBOL_NAME(name)) SEPARATOR                              \
   SYMBOL_IS_FUNC(SYMBOL_NAME(name)) SEPARATOR                                  \
   DECLARE_SYMBOL_VISIBILITY(name) SEPARATOR                                    \
-  .set FUNC_SYMBOL(SYMBOL_NAME(name)), FUNC_SYMBOL(target) SEPARATOR
+  .set FUNC_SYMBOL(SYMBOL_NAME(name)), FUNC_SYMBOL(SYMBOL_NAME(target)) SEPARATOR
 
 #if defined(__ARM_EABI__)
 #define DEFINE_AEABI_FUNCTION_ALIAS(aeabi_name, name)                          \


        


More information about the llvm-commits mailing list