[llvm] [Offload] Make `ASSERT_ERROR` output more readable (PR #157653)
via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 9 04:49:19 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-offload
Author: Ross Brunton (RossBrunton)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/157653.diff
1 Files Affected:
- (modified) offload/unittests/OffloadAPI/common/Fixtures.hpp (+6-2)
``````````diff
diff --git a/offload/unittests/OffloadAPI/common/Fixtures.hpp b/offload/unittests/OffloadAPI/common/Fixtures.hpp
index c5a35faba7a27..6f9961e2c6d58 100644
--- a/offload/unittests/OffloadAPI/common/Fixtures.hpp
+++ b/offload/unittests/OffloadAPI/common/Fixtures.hpp
@@ -40,12 +40,16 @@
} while (0)
#endif
-// TODO: rework this so the EXPECTED/ACTUAL results are readable
#ifndef ASSERT_ERROR
#define ASSERT_ERROR(EXPECTED, ACTUAL) \
do { \
ol_result_t Res = ACTUAL; \
- ASSERT_TRUE(Res && (Res->Code == EXPECTED)); \
+ if (!Res) \
+ GTEST_FAIL() << #ACTUAL " succeeded when we expected it to fail"; \
+ if (Res->Code != EXPECTED) \
+ GTEST_FAIL() << #ACTUAL " was expected to return " \
+ << #EXPECTED " but instead returned " << Res->Code << ": " \
+ << Res->Details; \
} while (0)
#endif
``````````
</details>
https://github.com/llvm/llvm-project/pull/157653
More information about the llvm-commits
mailing list