[clang] [clang-tools-extra] [compiler-rt] [Clang] [Sema] Make `-Wincompatible-pointer-types` an error by default (PR #157364)

[via llvm-commits]

Sirraide wrote:

> IIRC the Clang behaviour for `-Wincompatible-pointer-types` differs from GCC as it includes qualifiers while GCC doesn't, so it may show up with some new failures. That's not a comment for or against changing it.

Sort of: while `-Werror=incompatible-pointer-types` *would* indeed make e.g. `const char*` -> `char*` ill-formed as well, that only applies if you make the entire warning group an error. This pr is only making a single warning an error, so e.g. `const char*` -> `char*` is still just a warning.




https://github.com/llvm/llvm-project/pull/157364