[clang] [clang-tools-extra] [compiler-rt] [Clang] [Sema] Make `-Wincompatible-pointer-types` an error by default (PR #157364)

[via llvm-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cl,c -- clang-tools-extra/test/clang-tidy/checkers/bugprone/easily-swappable-parameters-implicits.c clang/test/APINotes/nullability.c clang/test/AST/ByteCode/atomic.c clang/test/AST/ByteCode/c.c clang/test/Analysis/OSAtomic_mac.c clang/test/Analysis/bsd-string.c clang/test/Analysis/novoidtypecrash.c clang/test/Analysis/override-werror.c clang/test/Analysis/uninit-vals-union.c clang/test/C/C23/n3007.c clang/test/C/C2y/n3369.c clang/test/C/drs/dr0xx.c clang/test/CodeGen/2008-03-05-syncPtr.c clang/test/CodeGen/X86/cmpccxadd-builtins-error.c clang/test/CodeGen/X86/math-builtins.c clang/test/CodeGen/arm64-microsoft-intrinsics.c clang/test/CodeGen/builtin-rename.c clang/test/CodeGen/ms-intrinsics-underaligned.c clang/test/CodeGen/ubsan-pass-object-size.c clang/test/CodeGen/vla.c clang/test/CodeGen/vlt_to_pointer.c clang/test/Frontend/fixed_point_unknown_conversions.c clang/test/Index/preamble.c clang/test/Index/warning-flags.c clang/test/Misc/remap-file.c clang/test/Modules/diamond-pch.c clang/test/Modules/diamond.c clang/test/OpenMP/vla_crash.c clang/test/PCH/functions.c clang/test/PCH/variables.c clang/test/Parser/declarators.c clang/test/Sema/MicrosoftExtensions.c clang/test/Sema/atomic-expr.c clang/test/Sema/atomic-ops.c clang/test/Sema/attr-format.c clang/test/Sema/c2x-auto.c clang/test/Sema/conditional-expr.c clang/test/Sema/decl-type-merging.c clang/test/Sema/enum.c clang/test/Sema/format-strings.c clang/test/Sema/function.c clang/test/Sema/merge-decls.c clang/test/Sema/nullability.c clang/test/Sema/pass-object-size.c clang/test/Sema/ptrauth-atomic-ops.c clang/test/Sema/ptrauth.c clang/test/Sema/static-array.c clang/test/Sema/struct-compat.c clang/test/Sema/var-redecl.c clang/test/Sema/vector-assign.c clang/test/Sema/vla.c clang/test/SemaOpenACC/combined-construct-if-clause.c clang/test/SemaOpenACC/compute-construct-if-clause.c clang/test/SemaOpenCL/address-spaces.cl clang/test/SemaOpenCL/atomic-ops.cl clang/test/SemaOpenCL/to_addr_builtin.cl compiler-rt/test/safestack/pthread-cleanup.c compiler-rt/test/tysan/violation-pr62544.c
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/compiler-rt/test/safestack/pthread-cleanup.c b/compiler-rt/test/safestack/pthread-cleanup.c
index 26f908924..c2645a650 100644
--- a/compiler-rt/test/safestack/pthread-cleanup.c
+++ b/compiler-rt/test/safestack/pthread-cleanup.c
@@ -28,7 +28,7 @@ int main(int argc, char **argv)
 
   if (pthread_create(&t1, NULL, start, NULL))
     abort();
-  if (pthread_join(t1, (void**)&t1_buffer))
+  if (pthread_join(t1, (void **)&t1_buffer))
     abort();
 
   // Stack has not yet been deallocated
diff --git a/compiler-rt/test/tysan/violation-pr62544.c b/compiler-rt/test/tysan/violation-pr62544.c
index ddf51f879..d779abd66 100644
--- a/compiler-rt/test/tysan/violation-pr62544.c
+++ b/compiler-rt/test/tysan/violation-pr62544.c
@@ -7,7 +7,7 @@ int printf(const char *, ...);
 int a, b, c;
 long d;
 int main() {
-  short *e = (short*)&a;
+  short *e = (short *)&a;
   int *f = &a;
   *f = 0;
   for (; b <= 9; b++) {

``````````

</details>


https://github.com/llvm/llvm-project/pull/157364