[llvm] [Verifier][AMDGPU] Restrict targets for chain calling convention. (PR #157469)

[via llvm-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-llvm-ir

Author: None (jofrn)

<details>
<summary>Changes</summary>

The chain calling convention is invalid in particular situations like being on an architecture it cannot compile to.

---
Full diff: https://github.com/llvm/llvm-project/pull/157469.diff


2 Files Affected:

- (modified) llvm/lib/IR/Verifier.cpp (+8-2) 
- (added) llvm/test/CodeGen/AMDGPU/amdgpu-cs-chain-invalid-arch.ll (+6) 


``````````diff
diff --git a/llvm/lib/IR/Verifier.cpp b/llvm/lib/IR/Verifier.cpp
index 1d3c379f461fa..63ae083fec8e8 100644
--- a/llvm/lib/IR/Verifier.cpp
+++ b/llvm/lib/IR/Verifier.cpp
@@ -2938,10 +2938,16 @@ void Verifier::visitFunction(const Function &F) {
           "Calling convention parameter requires byval", &F);
     break;
   }
-  case CallingConv::AMDGPU_KERNEL:
-  case CallingConv::SPIR_KERNEL:
   case CallingConv::AMDGPU_CS_Chain:
   case CallingConv::AMDGPU_CS_ChainPreserve:
+  {
+    auto TT = M.getTargetTriple().str();
+    if (TT.find("gfx1200") || TT.find("gfx942"))
+      Check(false, "Chain calling convention is invalid on this target", &F);
+  }
+    [[fallthrough]];
+  case CallingConv::AMDGPU_KERNEL:
+  case CallingConv::SPIR_KERNEL:
     Check(F.getReturnType()->isVoidTy(),
           "Calling convention requires void return type", &F);
     [[fallthrough]];
diff --git a/llvm/test/CodeGen/AMDGPU/amdgpu-cs-chain-invalid-arch.ll b/llvm/test/CodeGen/AMDGPU/amdgpu-cs-chain-invalid-arch.ll
new file mode 100644
index 0000000000000..c6f8a09eaf5b6
--- /dev/null
+++ b/llvm/test/CodeGen/AMDGPU/amdgpu-cs-chain-invalid-arch.ll
@@ -0,0 +1,6 @@
+; RUN: not llc -mtriple=amdgcn -mcpu=gfx1200 -o - < %s 2>&1 | FileCheck %s
+
+define amdgpu_cs_chain void @test_alloca() {
+; CHECK: Chain calling convention is invalid on this target
+  ret void
+}

``````````

</details>


https://github.com/llvm/llvm-project/pull/157469