[llvm] [llvm] Validate Parent object before dereference (PR #157460)
Daniel Kuts via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 8 06:28:28 PDT 2025
https://github.com/apach301 created https://github.com/llvm/llvm-project/pull/157460
Fixes #157449
>From 2894721aa05bbef0b9e5642e0e0c85045aac7446 Mon Sep 17 00:00:00 2001
From: Daniil Kutz <kutz at ispras.ru>
Date: Mon, 8 Sep 2025 16:10:32 +0300
Subject: [PATCH] [llvm] Validate Parent object before dereference
---
llvm/lib/Object/Archive.cpp | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/llvm/lib/Object/Archive.cpp b/llvm/lib/Object/Archive.cpp
index 92f31c909efd4..c3111ebe0f525 100644
--- a/llvm/lib/Object/Archive.cpp
+++ b/llvm/lib/Object/Archive.cpp
@@ -472,10 +472,11 @@ Archive::Child::Child(const Archive *Parent, const char *Start, Error *Err)
return;
}
+ assert(Parent && "Parent can't be nullptr if Start is not a nullptr");
+
Header = Parent->createArchiveMemberHeader(
Start,
- Parent ? Parent->getData().size() - (Start - Parent->getData().data())
- : 0,
+ Parent->getData().size() - (Start - Parent->getData().data()),
Err);
// If we are pointed to real data, Start is not a nullptr, then there must be
More information about the llvm-commits
mailing list