[llvm] [InstCombine][VectorCombine][NFC] Unify uses of lossless inverse cast (PR #156597)

[LLVM Continuous Integration via llvm-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `fuchsia-x86_64-linux` running on `fuchsia-debian-64-us-central1-a-1` while building `llvm` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/11/builds/23497

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (annotate) failure: 'python ../llvm-zorg/zorg/buildbot/builders/annotated/fuchsia-linux.py ...' (failure)
...
[693/1422] Building CXX object unittests/ADT/CMakeFiles/ADTTests.dir/PointerEmbeddedIntTest.cpp.o
[694/1422] Building CXX object tools/clang/unittests/Sema/CMakeFiles/SemaTests.dir/HeuristicResolverTest.cpp.o
[695/1422] Linking CXX executable bin/yaml2obj
[695/1422] Running lld test suite
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:527: note: using ld.lld: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-v2g_w8yy/bin/ld.lld
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:527: note: using lld-link: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-v2g_w8yy/bin/lld-link
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:527: note: using ld64.lld: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-v2g_w8yy/bin/ld64.lld
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:527: note: using wasm-ld: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-v2g_w8yy/bin/wasm-ld
-- Testing: 3138 tests, 60 workers --
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80..
FAIL: lld :: MachO/read-workers.s (2810 of 3138)
******************** TEST 'lld :: MachO/read-workers.s' FAILED ********************
Exit Code: -11

Command Output (stdout):
--
# RUN: at line 2
/var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-v2g_w8yy/bin/llvm-mc -filetype=obj -triple=x86_64-apple-darwin /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/lld/test/MachO/read-workers.s -o /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-v2g_w8yy/tools/lld/test/MachO/Output/read-workers.s.tmp.o
# executed command: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-v2g_w8yy/bin/llvm-mc -filetype=obj -triple=x86_64-apple-darwin /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/lld/test/MachO/read-workers.s -o /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-v2g_w8yy/tools/lld/test/MachO/Output/read-workers.s.tmp.o
# RUN: at line 5
ld64.lld -arch x86_64 -platform_version macos 11.0 11.0 -syslibroot /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/lld/test/MachO/Inputs/MacOSX.sdk -lSystem -fatal_warnings --read-workers=0 /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-v2g_w8yy/tools/lld/test/MachO/Output/read-workers.s.tmp.o -o /dev/null
# executed command: ld64.lld -arch x86_64 -platform_version macos 11.0 11.0 -syslibroot /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/lld/test/MachO/Inputs/MacOSX.sdk -lSystem -fatal_warnings --read-workers=0 /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-v2g_w8yy/tools/lld/test/MachO/Output/read-workers.s.tmp.o -o /dev/null
# RUN: at line 6
ld64.lld -arch x86_64 -platform_version macos 11.0 11.0 -syslibroot /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/lld/test/MachO/Inputs/MacOSX.sdk -lSystem -fatal_warnings --read-workers=1 /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-v2g_w8yy/tools/lld/test/MachO/Output/read-workers.s.tmp.o -o /dev/null
# executed command: ld64.lld -arch x86_64 -platform_version macos 11.0 11.0 -syslibroot /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/lld/test/MachO/Inputs/MacOSX.sdk -lSystem -fatal_warnings --read-workers=1 /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-v2g_w8yy/tools/lld/test/MachO/Output/read-workers.s.tmp.o -o /dev/null
# RUN: at line 7
ld64.lld -arch x86_64 -platform_version macos 11.0 11.0 -syslibroot /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/lld/test/MachO/Inputs/MacOSX.sdk -lSystem -fatal_warnings --read-workers=2 /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-v2g_w8yy/tools/lld/test/MachO/Output/read-workers.s.tmp.o -o /dev/null
# executed command: ld64.lld -arch x86_64 -platform_version macos 11.0 11.0 -syslibroot /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/lld/test/MachO/Inputs/MacOSX.sdk -lSystem -fatal_warnings --read-workers=2 /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-v2g_w8yy/tools/lld/test/MachO/Output/read-workers.s.tmp.o -o /dev/null
# note: command had no output on stdout or stderr
# error: command failed with exit status: -11

--

********************
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
********************
Failed Tests (1):
  lld :: MachO/read-workers.s


Testing Time: 27.62s

Total Discovered Tests: 3138
  Unsupported:  569 (18.13%)
  Passed     : 2568 (81.84%)
  Failed     :    1 (0.03%)
[850/1422] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/TypeTraitsTest.cpp.o
FAILED: tools/lld/test/CMakeFiles/check-lld /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-v2g_w8yy/tools/lld/test/CMakeFiles/check-lld 
cd /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-v2g_w8yy/tools/lld/test && /usr/bin/python3.10 /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-v2g_w8yy/./bin/llvm-lit -sv /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-v2g_w8yy/tools/lld/test
Step 7 (check) failure: check (failure)
...
[693/1422] Building CXX object unittests/ADT/CMakeFiles/ADTTests.dir/PointerEmbeddedIntTest.cpp.o
[694/1422] Building CXX object tools/clang/unittests/Sema/CMakeFiles/SemaTests.dir/HeuristicResolverTest.cpp.o
[695/1422] Linking CXX executable bin/yaml2obj
[695/1422] Running lld test suite
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:527: note: using ld.lld: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-v2g_w8yy/bin/ld.lld
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:527: note: using lld-link: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-v2g_w8yy/bin/lld-link
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:527: note: using ld64.lld: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-v2g_w8yy/bin/ld64.lld
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:527: note: using wasm-ld: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-v2g_w8yy/bin/wasm-ld
-- Testing: 3138 tests, 60 workers --
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80..
FAIL: lld :: MachO/read-workers.s (2810 of 3138)
******************** TEST 'lld :: MachO/read-workers.s' FAILED ********************
Exit Code: -11

Command Output (stdout):
--
# RUN: at line 2
/var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-v2g_w8yy/bin/llvm-mc -filetype=obj -triple=x86_64-apple-darwin /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/lld/test/MachO/read-workers.s -o /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-v2g_w8yy/tools/lld/test/MachO/Output/read-workers.s.tmp.o
# executed command: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-v2g_w8yy/bin/llvm-mc -filetype=obj -triple=x86_64-apple-darwin /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/lld/test/MachO/read-workers.s -o /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-v2g_w8yy/tools/lld/test/MachO/Output/read-workers.s.tmp.o
# RUN: at line 5
ld64.lld -arch x86_64 -platform_version macos 11.0 11.0 -syslibroot /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/lld/test/MachO/Inputs/MacOSX.sdk -lSystem -fatal_warnings --read-workers=0 /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-v2g_w8yy/tools/lld/test/MachO/Output/read-workers.s.tmp.o -o /dev/null
# executed command: ld64.lld -arch x86_64 -platform_version macos 11.0 11.0 -syslibroot /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/lld/test/MachO/Inputs/MacOSX.sdk -lSystem -fatal_warnings --read-workers=0 /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-v2g_w8yy/tools/lld/test/MachO/Output/read-workers.s.tmp.o -o /dev/null
# RUN: at line 6
ld64.lld -arch x86_64 -platform_version macos 11.0 11.0 -syslibroot /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/lld/test/MachO/Inputs/MacOSX.sdk -lSystem -fatal_warnings --read-workers=1 /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-v2g_w8yy/tools/lld/test/MachO/Output/read-workers.s.tmp.o -o /dev/null
# executed command: ld64.lld -arch x86_64 -platform_version macos 11.0 11.0 -syslibroot /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/lld/test/MachO/Inputs/MacOSX.sdk -lSystem -fatal_warnings --read-workers=1 /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-v2g_w8yy/tools/lld/test/MachO/Output/read-workers.s.tmp.o -o /dev/null
# RUN: at line 7
ld64.lld -arch x86_64 -platform_version macos 11.0 11.0 -syslibroot /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/lld/test/MachO/Inputs/MacOSX.sdk -lSystem -fatal_warnings --read-workers=2 /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-v2g_w8yy/tools/lld/test/MachO/Output/read-workers.s.tmp.o -o /dev/null
# executed command: ld64.lld -arch x86_64 -platform_version macos 11.0 11.0 -syslibroot /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/lld/test/MachO/Inputs/MacOSX.sdk -lSystem -fatal_warnings --read-workers=2 /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-v2g_w8yy/tools/lld/test/MachO/Output/read-workers.s.tmp.o -o /dev/null
# note: command had no output on stdout or stderr
# error: command failed with exit status: -11

--

********************
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
********************
Failed Tests (1):
  lld :: MachO/read-workers.s


Testing Time: 27.62s

Total Discovered Tests: 3138
  Unsupported:  569 (18.13%)
  Passed     : 2568 (81.84%)
  Failed     :    1 (0.03%)
[850/1422] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/TypeTraitsTest.cpp.o
FAILED: tools/lld/test/CMakeFiles/check-lld /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-v2g_w8yy/tools/lld/test/CMakeFiles/check-lld 
cd /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-v2g_w8yy/tools/lld/test && /usr/bin/python3.10 /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-v2g_w8yy/./bin/llvm-lit -sv /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-v2g_w8yy/tools/lld/test

```

</details>

https://github.com/llvm/llvm-project/pull/156597