[llvm] [AMDGPU] Remove setcc by using add/sub carryout (PR #155255)
Matt Arsenault via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 5 19:18:25 PDT 2025
================
@@ -16036,6 +16036,61 @@ SDValue SITargetLowering::performSetCCCombine(SDNode *N,
}
}
+ // Eliminate setcc by using carryout from add/sub instruction
+
+ // LHS = ADD i64 RHS, Z LHSlo = UADDO i32 RHSlo, Zlo
+ // setcc LHS ult RHS -> LHSHi = UADDO_CARRY i32 RHShi, Zhi
+ // similarly for subtraction
+
+ // LHS = ADD i64 Y, 1 LHSlo = UADDO i32 Ylo, 1
+ // setcc LHS eq 0 -> LHSHi = UADDO_CARRY i32 Yhi, 0
+
+ // Don't split a 64-bit add/sub into two 32-bit add/sub instructions for
+ // non-divergent operations. This can result in lo/hi 32-bit operations
+ // being done in SGPR and VGPR with additional operations being needed
+ // to move operands and/or generate the intermediate carry.
+ if (VT == MVT::i64 && N->isDivergent() &&
----------------
arsenm wrote:
Not sure why this needs to check isDivergent, the same logic should apply for SALU too?
https://github.com/llvm/llvm-project/pull/155255
More information about the llvm-commits
mailing list