[compiler-rt] 5cf4959 - [scudo] Move getPageSize() decl to common.h header (#157146)

via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 5 11:48:42 PDT 2025


Author: Roland McGrath
Date: 2025-09-05T11:48:38-07:00
New Revision: 5cf4959b2121aac82f86b10a2c9b9faa74fedda9

URL: https://github.com/llvm/llvm-project/commit/5cf4959b2121aac82f86b10a2c9b9faa74fedda9
DIFF: https://github.com/llvm/llvm-project/commit/5cf4959b2121aac82f86b10a2c9b9faa74fedda9.diff

LOG: [scudo] Move getPageSize() decl to common.h header (#157146)

The getPageSize() function is defined in the platform-specific
source files but used in common.cpp.  Every function used across
files should be declared in a header so the same declaration is
in scope for the callers and the definition.

Added: 
    

Modified: 
    compiler-rt/lib/scudo/standalone/common.cpp
    compiler-rt/lib/scudo/standalone/common.h

Removed: 
    


################################################################################
diff  --git a/compiler-rt/lib/scudo/standalone/common.cpp b/compiler-rt/lib/scudo/standalone/common.cpp
index 80134c39e757d..f7c1b420f4c77 100644
--- a/compiler-rt/lib/scudo/standalone/common.cpp
+++ b/compiler-rt/lib/scudo/standalone/common.cpp
@@ -16,9 +16,6 @@ namespace scudo {
 uptr PageSizeCached = 0;
 uptr PageSizeLogCached = 0;
 
-// Must be defined in platform specific code.
-uptr getPageSize();
-
 // This must be called in the init path or there could be a race if multiple
 // threads try to set the cached values.
 uptr getPageSizeSlow() {

diff  --git a/compiler-rt/lib/scudo/standalone/common.h b/compiler-rt/lib/scudo/standalone/common.h
index e5dfda2e9072a..8adcebd55698d 100644
--- a/compiler-rt/lib/scudo/standalone/common.h
+++ b/compiler-rt/lib/scudo/standalone/common.h
@@ -148,6 +148,10 @@ inline constexpr uptr getPageSizeLogCached() {
 extern uptr PageSizeCached;
 extern uptr PageSizeLogCached;
 
+// Must be defined in platform specific code.
+uptr getPageSize();
+
+// Always calls getPageSize(), but caches the results for get*Cached(), below.
 uptr getPageSizeSlow();
 
 inline uptr getPageSizeCached() {


        


More information about the llvm-commits mailing list