[lld] [llvm] [llvm-readobj][ELF] Prints hex format values in lower-case mode (PR #156683)
James Henderson via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 5 04:47:30 PDT 2025
https://github.com/jh7370 approved this pull request.
I'd suggest some slight grammar changes to the PR description:
> Previously, llvm-readelf dumped hex format values in different ways. Some of them were printed in upper-case, while the others were in lower-case format. This change switches the format to lower-case in all cases.
>
> Why is this useful? As an example, FileCheck comparisons are case-sensitive by default. This change means it's easier to compare those values, because they have the same format.
I've dropped the "where it is possible" bit. There aren't any within the llvm-readelf code that aren't possible, right?
You can also drop the "the corresponding tests have been updated as well" since that's normal procedure.
With those tweaks and the one nit in the release note, LGTM. Do you need assistance merging, or do you have commit access already?
https://github.com/llvm/llvm-project/pull/156683
More information about the llvm-commits
mailing list