[compiler-rt] [compiler-rt][ASan] Work around msvc cl x64 build warnings (PR #156887)
Zack Johnson via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 4 08:28:16 PDT 2025
================
@@ -108,7 +108,8 @@ set(ASAN_CFLAGS ${SANITIZER_COMMON_CFLAGS})
# Win/ASan relies on the runtime functions being hotpatchable. See
# https://github.com/llvm/llvm-project/pull/149444
-if(MSVC)
+# MSVC cl 64 bit architectures treat /hotpatch as an unknown option
+if(CLANG_CL OR (MSVC AND "i386" IN_LIST ASAN_SUPPORTED_ARCH))
----------------
zacklj89 wrote:
`CLANG_CL` is also used a few lines down to silence some other warnings related to MSVC. I'm wondering if I have something locally that is precluding me from seeing the same issues you are.
https://github.com/llvm/llvm-project/pull/156887
More information about the llvm-commits
mailing list