[llvm] [BOLT][AArch64] Enabling Inlining for Memcpy for AArch64 in BOLT (PR #154929)

[Paschalis Mpeis via llvm-commits]

================
@@ -2597,6 +2597,121 @@ class AArch64MCPlusBuilder : public MCPlusBuilder {
   getInstructionSize(const MCInst &Inst) const override {
     return 4;
   }
+
+  InstructionListType createInlineMemcpy(bool ReturnEnd) const override {
+    return createInlineMemcpy(ReturnEnd, std::nullopt);
+  }
----------------
paschalis-mpeis wrote:

Can you move this next to the other `createInlineMemcpy`?

Or is an implementation needed at all here?
`createInlineMemcpy(bool)` is no longer called, correct? If it is, dereferencing the optional in the inner call will crash.

Alternatively, it may be cleaner to keep a single `createInlineMemcpy` in MCPlusBuilder (the two arguments overload). What do others think?

https://github.com/llvm/llvm-project/pull/154929