[llvm] Revert "[llvm-exegesis] Exclude loads/stores from aliasing instruction set" (PR #156735)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 3 12:01:50 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-tools-llvm-exegesis
Author: Sjoerd Meijer (sjoerdmeijer)
<details>
<summary>Changes</summary>
Reverts llvm/llvm-project#<!-- -->156300
Need to look at the X86 test failures.
---
Full diff: https://github.com/llvm/llvm-project/pull/156735.diff
2 Files Affected:
- (removed) llvm/test/tools/llvm-exegesis/AArch64/no-aliasing-ld-str.s (-8)
- (modified) llvm/tools/llvm-exegesis/lib/MCInstrDescView.cpp (-2)
``````````diff
diff --git a/llvm/test/tools/llvm-exegesis/AArch64/no-aliasing-ld-str.s b/llvm/test/tools/llvm-exegesis/AArch64/no-aliasing-ld-str.s
deleted file mode 100644
index 65e1203bb275d..0000000000000
--- a/llvm/test/tools/llvm-exegesis/AArch64/no-aliasing-ld-str.s
+++ /dev/null
@@ -1,8 +0,0 @@
-REQUIRES: aarch64-registered-target
-
-RUN: llvm-exegesis -mtriple=aarch64 -mcpu=neoverse-v2 -mode=latency --dump-object-to-disk=%d --opcode-name=FMOVWSr --benchmark-phase=assemble-measured-code 2>&1
-RUN: llvm-objdump -d %d > %t.s
-RUN: FileCheck %s < %t.s
-
-CHECK-NOT: ld{{[1-4]}}
-CHECK-NOT: st{{[1-4]}}
diff --git a/llvm/tools/llvm-exegesis/lib/MCInstrDescView.cpp b/llvm/tools/llvm-exegesis/lib/MCInstrDescView.cpp
index d2d9b31df5197..66c770d9ca86b 100644
--- a/llvm/tools/llvm-exegesis/lib/MCInstrDescView.cpp
+++ b/llvm/tools/llvm-exegesis/lib/MCInstrDescView.cpp
@@ -206,8 +206,6 @@ const Operand &Instruction::getPrimaryOperand(const Variable &Var) const {
}
bool Instruction::hasMemoryOperands() const {
- if (Description.mayLoad() || Description.mayStore())
- return true;
return any_of(Operands, [](const Operand &Op) {
return Op.isReg() && Op.isExplicit() && Op.isMemory();
});
``````````
</details>
https://github.com/llvm/llvm-project/pull/156735
More information about the llvm-commits
mailing list