[llvm] [MC] Add .loc_label instruction (PR #99710)

[Peter Rong via llvm-commits]

DataCorrupted wrote:

I'm on PTO and won't have a laptop until Friday. But I think the test added
in this PR is a pretty good example.

Yuyang (Peter) Rong
Research Scientise @ Meta

On Wed, Sep 3, 2025, 9:36 AM David Blaikie ***@***.***> wrote:

> ***@***.**** commented on this pull request.
> ------------------------------
>
> In llvm/lib/MC/MCDwarf.cpp
> <https://github.com/llvm/llvm-project/pull/99710#discussion_r2319519104>:
>
> > @@ -189,6 +191,17 @@ void MCDwarfLineTable::emitOne(
>    for (const MCDwarfLineEntry &LineEntry : LineEntries) {
>      MCSymbol *Label = LineEntry.getLabel();
>      const MCAsmInfo *asmInfo = MCOS->getContext().getAsmInfo();
> +
> +    if (LineEntry.LineStreamLabel) {
> +      if (!IsAtStartSeq) {
> +        MCOS->emitDwarfLineEndEntry(Section, LastLabel,
>
> I don't think I can tell if this is correct or incorrect without seeing
> the code it's describing...
>
> Perhaps a small/smallest hand-written assembly example, and the
> llvm-dwarfdump of the line table would be a good thing to show/discuss?
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/llvm/llvm-project/pull/99710#discussion_r2319519104>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AFQQFGDTPTNB2DH6JFLZMVL3Q4KKFAVCNFSM6AAAAACFOXX7LOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTCOBRGQ2DINRRGU>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>


https://github.com/llvm/llvm-project/pull/99710