[llvm] MSP430: Do not add target specific STI member to MSP430AsmParser (PR #156443)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 3 09:04:45 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-backend-msp430
Author: Matt Arsenault (arsenm)
<details>
<summary>Changes</summary>
The base class already has an STI pointer member, so use that.
---
Full diff: https://github.com/llvm/llvm-project/pull/156443.diff
1 Files Affected:
- (modified) llvm/lib/Target/MSP430/AsmParser/MSP430AsmParser.cpp (+2-3)
``````````diff
diff --git a/llvm/lib/Target/MSP430/AsmParser/MSP430AsmParser.cpp b/llvm/lib/Target/MSP430/AsmParser/MSP430AsmParser.cpp
index 38d22eda5f171..a31c8ec1b2bb5 100644
--- a/llvm/lib/Target/MSP430/AsmParser/MSP430AsmParser.cpp
+++ b/llvm/lib/Target/MSP430/AsmParser/MSP430AsmParser.cpp
@@ -36,7 +36,6 @@ namespace {
/// Parses MSP430 assembly from a stream.
class MSP430AsmParser : public MCTargetAsmParser {
- const MCSubtargetInfo &STI;
MCAsmParser &Parser;
const MCRegisterInfo *MRI;
@@ -79,7 +78,7 @@ class MSP430AsmParser : public MCTargetAsmParser {
public:
MSP430AsmParser(const MCSubtargetInfo &STI, MCAsmParser &Parser,
const MCInstrInfo &MII, const MCTargetOptions &Options)
- : MCTargetAsmParser(Options, STI, MII), STI(STI), Parser(Parser) {
+ : MCTargetAsmParser(Options, STI, MII), Parser(Parser) {
MCAsmParserExtension::Initialize(Parser);
MRI = getContext().getRegisterInfo();
@@ -264,7 +263,7 @@ bool MSP430AsmParser::matchAndEmitInstruction(SMLoc Loc, unsigned &Opcode,
switch (MatchResult) {
case Match_Success:
Inst.setLoc(Loc);
- Out.emitInstruction(Inst, STI);
+ Out.emitInstruction(Inst, *STI);
return false;
case Match_MnemonicFail:
return Error(Loc, "invalid instruction mnemonic");
``````````
</details>
https://github.com/llvm/llvm-project/pull/156443
More information about the llvm-commits
mailing list