[llvm] [X86][GlobalIsel] Support G_INTRINSIC_TRUNC/G_FCEIL/G_FFLOOR (PR #156633)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 3 02:47:15 PDT 2025
https://github.com/mahesh-attarde created https://github.com/llvm/llvm-project/pull/156633
This PR adds support for C/CPP Lib Intrinsic G_INTRINSIC_TRUNC/G_FCEIL/G_FFLOOR from LangRef in GlobalIsel.
>From c9b41e4724c93b9f4a259754b1a0ca4e3fbda3a6 Mon Sep 17 00:00:00 2001
From: mattarde <mattarde at intel.com>
Date: Wed, 3 Sep 2025 02:44:19 -0700
Subject: [PATCH] add gisel output
---
.../lib/Target/X86/GISel/X86LegalizerInfo.cpp | 3 +-
llvm/test/CodeGen/X86/isel-ceil.ll | 30 +++++-----------
llvm/test/CodeGen/X86/isel-floor.ll | 30 +++++-----------
llvm/test/CodeGen/X86/isel-ftrunc.ll | 34 ++++++-------------
4 files changed, 31 insertions(+), 66 deletions(-)
diff --git a/llvm/lib/Target/X86/GISel/X86LegalizerInfo.cpp b/llvm/lib/Target/X86/GISel/X86LegalizerInfo.cpp
index 7fe58539cd4ec..c27e6075c779f 100644
--- a/llvm/lib/Target/X86/GISel/X86LegalizerInfo.cpp
+++ b/llvm/lib/Target/X86/GISel/X86LegalizerInfo.cpp
@@ -580,7 +580,8 @@ X86LegalizerInfo::X86LegalizerInfo(const X86Subtarget &STI,
.lower();
// fp intrinsics
- getActionDefinitionsBuilder(G_INTRINSIC_ROUNDEVEN)
+ getActionDefinitionsBuilder(
+ {G_INTRINSIC_ROUNDEVEN, G_INTRINSIC_TRUNC, G_FCEIL, G_FFLOOR})
.scalarize(0)
.minScalar(0, LLT::scalar(32))
.libcall();
diff --git a/llvm/test/CodeGen/X86/isel-ceil.ll b/llvm/test/CodeGen/X86/isel-ceil.ll
index c82cfebd4814d..eecaa79f2ef70 100644
--- a/llvm/test/CodeGen/X86/isel-ceil.ll
+++ b/llvm/test/CodeGen/X86/isel-ceil.ll
@@ -18,18 +18,12 @@ define float @ceil_f32(float %a) nounwind readnone {
; FASTISEL-X64-NEXT: popq %rax
; FASTISEL-X64-NEXT: retq
;
-; X86-LABEL: ceil_f32:
-; X86: # %bb.0:
-; X86-NEXT: subl $12, %esp
-; X86-NEXT: flds {{[0-9]+}}(%esp)
-; X86-NEXT: fstps (%esp)
-; X86-NEXT: calll ceilf
-; X86-NEXT: addl $12, %esp
-; X86-NEXT: retl
-;
; GISEL-X64-LABEL: ceil_f32:
; GISEL-X64: # %bb.0:
-; GISEL-X64-NEXT: jmp ceilf at PLT # TAILCALL
+; GISEL-X64-NEXT: pushq %rax
+; GISEL-X64-NEXT: callq ceilf
+; GISEL-X64-NEXT: popq %rax
+; GISEL-X64-NEXT: retq
%c = call float @llvm.ceil.f32(float %a)
ret float %c
}
@@ -46,18 +40,12 @@ define double @ceil_f64(double %a) nounwind readnone {
; FASTISEL-X64-NEXT: popq %rax
; FASTISEL-X64-NEXT: retq
;
-; X86-LABEL: ceil_f64:
-; X86: # %bb.0:
-; X86-NEXT: subl $12, %esp
-; X86-NEXT: fldl {{[0-9]+}}(%esp)
-; X86-NEXT: fstpl (%esp)
-; X86-NEXT: calll ceil
-; X86-NEXT: addl $12, %esp
-; X86-NEXT: retl
-;
; GISEL-X64-LABEL: ceil_f64:
; GISEL-X64: # %bb.0:
-; GISEL-X64-NEXT: jmp ceil at PLT # TAILCALL
+; GISEL-X64-NEXT: pushq %rax
+; GISEL-X64-NEXT: callq ceil
+; GISEL-X64-NEXT: popq %rax
+; GISEL-X64-NEXT: retq
%c = call double @llvm.ceil.f64(double %a)
ret double %c
}
@@ -86,7 +74,7 @@ define x86_fp80 @ceil_f80(x86_fp80 %a) nounwind readnone {
; GISEL-X64-NEXT: subq $24, %rsp
; GISEL-X64-NEXT: fldt {{[0-9]+}}(%rsp)
; GISEL-X64-NEXT: fstpt (%rsp)
-; GISEL-X64-NEXT: callq ceill at PLT
+; GISEL-X64-NEXT: callq ceill
; GISEL-X64-NEXT: addq $24, %rsp
; GISEL-X64-NEXT: retq
%c = call x86_fp80 @llvm.ceil.f80(x86_fp80 %a)
diff --git a/llvm/test/CodeGen/X86/isel-floor.ll b/llvm/test/CodeGen/X86/isel-floor.ll
index 675925b611263..4d98a27e7eb2f 100644
--- a/llvm/test/CodeGen/X86/isel-floor.ll
+++ b/llvm/test/CodeGen/X86/isel-floor.ll
@@ -18,18 +18,12 @@ define float @floor_f32(float %a) nounwind readnone {
; FASTISEL-X64-NEXT: popq %rax
; FASTISEL-X64-NEXT: retq
;
-; X86-LABEL: floor_f32:
-; X86: # %bb.0:
-; X86-NEXT: subl $12, %esp
-; X86-NEXT: flds {{[0-9]+}}(%esp)
-; X86-NEXT: fstps (%esp)
-; X86-NEXT: calll floorf
-; X86-NEXT: addl $12, %esp
-; X86-NEXT: retl
-;
; GISEL-X64-LABEL: floor_f32:
; GISEL-X64: # %bb.0:
-; GISEL-X64-NEXT: jmp floorf at PLT # TAILCALL
+; GISEL-X64-NEXT: pushq %rax
+; GISEL-X64-NEXT: callq floorf
+; GISEL-X64-NEXT: popq %rax
+; GISEL-X64-NEXT: retq
%c = call float @llvm.floor.f32(float %a)
ret float %c
}
@@ -46,18 +40,12 @@ define double @floor_f64(double %a) nounwind readnone {
; FASTISEL-X64-NEXT: popq %rax
; FASTISEL-X64-NEXT: retq
;
-; X86-LABEL: floor_f64:
-; X86: # %bb.0:
-; X86-NEXT: subl $12, %esp
-; X86-NEXT: fldl {{[0-9]+}}(%esp)
-; X86-NEXT: fstpl (%esp)
-; X86-NEXT: calll floor
-; X86-NEXT: addl $12, %esp
-; X86-NEXT: retl
-;
; GISEL-X64-LABEL: floor_f64:
; GISEL-X64: # %bb.0:
-; GISEL-X64-NEXT: jmp floor at PLT # TAILCALL
+; GISEL-X64-NEXT: pushq %rax
+; GISEL-X64-NEXT: callq floor
+; GISEL-X64-NEXT: popq %rax
+; GISEL-X64-NEXT: retq
%c = call double @llvm.floor.f64(double %a)
ret double %c
}
@@ -86,7 +74,7 @@ define x86_fp80 @floor_f80(x86_fp80 %a) nounwind readnone {
; GISEL-X64-NEXT: subq $24, %rsp
; GISEL-X64-NEXT: fldt {{[0-9]+}}(%rsp)
; GISEL-X64-NEXT: fstpt (%rsp)
-; GISEL-X64-NEXT: callq floorl at PLT
+; GISEL-X64-NEXT: callq floorl
; GISEL-X64-NEXT: addq $24, %rsp
; GISEL-X64-NEXT: retq
%c = call x86_fp80 @llvm.floor.f80(x86_fp80 %a)
diff --git a/llvm/test/CodeGen/X86/isel-ftrunc.ll b/llvm/test/CodeGen/X86/isel-ftrunc.ll
index 9bf06193961a3..cc9a7f4127c8d 100644
--- a/llvm/test/CodeGen/X86/isel-ftrunc.ll
+++ b/llvm/test/CodeGen/X86/isel-ftrunc.ll
@@ -3,8 +3,8 @@
; RUN: llc < %s -mtriple=x86_64-linux-gnu -fast-isel | FileCheck %s --check-prefixes=X64,FASTISEL-X64
; RUN: llc < %s -mtriple=i686-linux-gnu | FileCheck %s --check-prefixes=X86
; RUN: llc < %s -mtriple=i686-linux-gnu -fast-isel | FileCheck %s --check-prefixes=X86
-; RUN: llc < %s -mtriple=x86_64-linux-gnu -global-isel -global-isel-abort=2 | FileCheck %s --check-prefixes=GISEL-X64
-; RUN: llc < %s -mtriple=i686-linux-gnu -global-isel -global-isel-abort=2 | FileCheck %s --check-prefixes=X86
+; RUN: llc < %s -mtriple=x86_64-linux-gnu -global-isel -global-isel-abort=1 | FileCheck %s --check-prefixes=GISEL-X64
+; RUN: llc < %s -mtriple=i686-linux-gnu -global-isel -global-isel-abort=1 | FileCheck %s --check-prefixes=X86
define float @trunc_f32(float %a) nounwind readnone {
; DAG-X64-LABEL: trunc_f32:
@@ -18,18 +18,12 @@ define float @trunc_f32(float %a) nounwind readnone {
; FASTISEL-X64-NEXT: popq %rax
; FASTISEL-X64-NEXT: retq
;
-; X86-LABEL: trunc_f32:
-; X86: # %bb.0:
-; X86-NEXT: subl $12, %esp
-; X86-NEXT: flds {{[0-9]+}}(%esp)
-; X86-NEXT: fstps (%esp)
-; X86-NEXT: calll truncf
-; X86-NEXT: addl $12, %esp
-; X86-NEXT: retl
-;
; GISEL-X64-LABEL: trunc_f32:
; GISEL-X64: # %bb.0:
-; GISEL-X64-NEXT: jmp truncf at PLT # TAILCALL
+; GISEL-X64-NEXT: pushq %rax
+; GISEL-X64-NEXT: callq truncf
+; GISEL-X64-NEXT: popq %rax
+; GISEL-X64-NEXT: retq
%c = call float @llvm.trunc.f32(float %a)
ret float %c
}
@@ -46,18 +40,12 @@ define double @trunc_f64(double %a) nounwind readnone {
; FASTISEL-X64-NEXT: popq %rax
; FASTISEL-X64-NEXT: retq
;
-; X86-LABEL: trunc_f64:
-; X86: # %bb.0:
-; X86-NEXT: subl $12, %esp
-; X86-NEXT: fldl {{[0-9]+}}(%esp)
-; X86-NEXT: fstpl (%esp)
-; X86-NEXT: calll trunc
-; X86-NEXT: addl $12, %esp
-; X86-NEXT: retl
-;
; GISEL-X64-LABEL: trunc_f64:
; GISEL-X64: # %bb.0:
-; GISEL-X64-NEXT: jmp trunc at PLT # TAILCALL
+; GISEL-X64-NEXT: pushq %rax
+; GISEL-X64-NEXT: callq trunc
+; GISEL-X64-NEXT: popq %rax
+; GISEL-X64-NEXT: retq
%c = call double @llvm.trunc.f64(double %a)
ret double %c
}
@@ -86,7 +74,7 @@ define x86_fp80 @trunc_f80(x86_fp80 %a) nounwind readnone {
; GISEL-X64-NEXT: subq $24, %rsp
; GISEL-X64-NEXT: fldt {{[0-9]+}}(%rsp)
; GISEL-X64-NEXT: fstpt (%rsp)
-; GISEL-X64-NEXT: callq truncl at PLT
+; GISEL-X64-NEXT: callq truncl
; GISEL-X64-NEXT: addq $24, %rsp
; GISEL-X64-NEXT: retq
%c = call x86_fp80 @llvm.trunc.f80(x86_fp80 %a)
More information about the llvm-commits
mailing list