[clang] [llvm] [AMDGPU][gfx1250] Add 128B cooperative atomics (PR #156418)
Pierre van Houtryve via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 3 00:24:26 PDT 2025
================
@@ -145,6 +154,50 @@ bool SemaAMDGPU::CheckAMDGCNBuiltinFunctionCall(unsigned BuiltinID,
return false;
}
+bool SemaAMDGPU::checkCoopAtomicFunctionCall(CallExpr *TheCall, bool IsStore) {
+ bool Fail = false;
+
+ // First argument is a global or generic pointer.
+ Expr *PtrArg = TheCall->getArg(0);
+ QualType PtrTy = PtrArg->getType()->getPointeeType();
+ unsigned AS = getASTContext().getTargetAddressSpace(PtrTy.getAddressSpace());
+ if (AS != llvm::AMDGPUAS::FLAT_ADDRESS &&
+ AS != llvm::AMDGPUAS::GLOBAL_ADDRESS) {
+ Fail = true;
+ Diag(TheCall->getBeginLoc(), diag::err_amdgcn_coop_atomic_invalid_as)
+ << PtrArg->getSourceRange();
+ }
+
+ // Check atomic ordering
+ Expr *AtomicOrdArg = TheCall->getArg(IsStore ? 2 : 1);
+ Expr::EvalResult AtomicOrdArgRes;
+ if (!AtomicOrdArg->EvaluateAsInt(AtomicOrdArgRes, getASTContext()))
+ llvm_unreachable("Intrinsic requires imm for atomic ordering argument!");
+ auto Ord =
----------------
Pierre-vh wrote:
The type is on the RHS once already, I don't think repeating the type again the LHS is good.
If I use unsigned instead then I need to cast this to `AtomicOrderingCABI` whenever I check it
https://github.com/llvm/llvm-project/pull/156418
More information about the llvm-commits
mailing list