[clang] [llvm] [DirectX] Removing dxbc DescriptorRange from mcbxdc (PR #154629)

Damyan Pepper via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 2 09:52:53 PDT 2025


================
@@ -30,7 +30,11 @@ LLVM_ABI bool verifyRegisterValue(uint32_t RegisterValue);
 LLVM_ABI bool verifyRegisterSpace(uint32_t RegisterSpace);
 LLVM_ABI bool verifyRootDescriptorFlag(uint32_t Version, uint32_t FlagsVal);
 LLVM_ABI bool verifyRangeType(uint32_t Type);
-LLVM_ABI bool verifyDescriptorRangeFlag(uint32_t Version, uint32_t Type,
+LLVM_ABI bool verifyDescriptorRangeFlag(uint32_t Version,
+                                        dxbc::DescriptorRangeType Type,
+                                        dxbc::DescriptorRangeFlags FlagsVal);
+LLVM_ABI bool verifyDescriptorRangeFlag(uint32_t Version,
----------------
damyanp wrote:

I'm missing some context here.  Did this mean to say `BinaryFormat/DXContainer.h`?  Why does adding a new overload of `verifyDescriptorRangeFlag` here make it unnecessary to include this file?

Is there a reason why the call site in RootSignatureMetadata.cpp couldn't be updated to the following?

```c++
        if (!hlsl::rootsig::verifyDescriptorRangeFlag(
                RSD.Version, Range.RangeType,
                static_cast<dxbc::DescriptorRangeFlags>(Range.Flags)))
```


https://github.com/llvm/llvm-project/pull/154629


More information about the llvm-commits mailing list