[llvm] [SLP][NFC] Refactor `if`s into `&&` (PR #156278)

Piotr Fusik via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 31 22:10:17 PDT 2025


https://github.com/pfusik created https://github.com/llvm/llvm-project/pull/156278

None

>From d23cd2240717373c9372dde15b3a60a406e3e8cc Mon Sep 17 00:00:00 2001
From: Piotr Fusik <p.fusik at samsung.com>
Date: Mon, 1 Sep 2025 07:09:00 +0200
Subject: [PATCH] [SLP][NFC] Refactor `if`s into `&&`

---
 llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp b/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
index 4d4f34a0bdd38..3a81d1d24e16c 100644
--- a/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
+++ b/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
@@ -967,9 +967,7 @@ class BinOpSameOpcodeHelper {
       return false;
     }
     bool equal(unsigned Opcode) {
-      if (Opcode == I->getOpcode())
-        return trySet(MainOpBIT, MainOpBIT);
-      return false;
+      return Opcode == I->getOpcode() && trySet(MainOpBIT, MainOpBIT);
     }
     unsigned getOpcode() const {
       MaskType Candidate = Mask & SeenBefore;
@@ -24179,9 +24177,7 @@ class HorizontalReduction {
         // previous vectorization attempts.
         if (any_of(VL, [&V](Value *RedVal) {
               auto *RedValI = dyn_cast<Instruction>(RedVal);
-              if (!RedValI)
-                return false;
-              return V.isDeleted(RedValI);
+              return RedValI && V.isDeleted(RedValI);
             }))
           break;
         V.buildTree(VL, IgnoreList);



More information about the llvm-commits mailing list