[llvm] [mlgo][inliner] Fix potential concurrency issue in local ThinLTO + IR2Vec cases (PR #156120)

Fri Aug 29 18:29:30 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `ml-opt-devrel-x86-64` running on `ml-opt-devrel-x86-64-b1` while building `llvm` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/175/builds/24385

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
66.966 [1541/53/2349] Building CXX object lib/Target/X86/MCTargetDesc/CMakeFiles/LLVMX86Desc.dir/X86WinCOFFStreamer.cpp.o
66.993 [1541/52/2350] Linking CXX static library lib/libLLVMX86Info.a
67.137 [1539/53/2351] Linking CXX static library lib/libLLVMX86Disassembler.a
67.203 [1539/52/2352] Linking CXX static library lib/libLLVMX86Desc.a
67.309 [1537/53/2353] Linking CXX static library lib/libLLVMX86AsmParser.a
67.314 [1537/52/2354] Linking CXX static library lib/libLLVMX86TargetMCA.a
68.452 [1537/51/2355] Building CXX object lib/Transforms/Coroutines/CMakeFiles/LLVMCoroutines.dir/CoroAnnotationElide.cpp.o
68.604 [1537/50/2356] Building CXX object lib/Transforms/IPO/CMakeFiles/LLVMipo.dir/AlwaysInliner.cpp.o
68.775 [1537/49/2357] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/ReplayInlineAdvisor.cpp.o
68.838 [1537/48/2358] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/DevelopmentModeInlineAdvisor.cpp.o
FAILED: lib/Analysis/CMakeFiles/LLVMAnalysis.dir/DevelopmentModeInlineAdvisor.cpp.o 
ccache /usr/bin/c++ -DCPUINFO_SUPPORTED_PLATFORM=1 -DGTEST_HAS_RTTI=0 -DLLVM_HAVE_TF_AOT_INLINERSIZEMODEL -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/b/ml-opt-devrel-x86-64-b1/build/lib/Analysis -I/b/ml-opt-devrel-x86-64-b1/llvm-project/llvm/lib/Analysis -I/var/lib/buildbot/.local/lib/python3.7/site-packages/tensorflow/include -I/b/ml-opt-devrel-x86-64-b1/build/include -I/b/ml-opt-devrel-x86-64-b1/llvm-project/llvm/include -isystem /tmp/tflitebuild/tensorflow/include -isystem /tmp/tflitebuild/eigen/include/eigen3 -isystem /tmp/tflitebuild/abseil-cpp/include -isystem /tmp/tflitebuild/flatbuffers/include -isystem /tmp/tflitebuild/gemmlowp/include/gemmlowp -isystem /tmp/tflitebuild/ml_dtypes/src/ml_dtypes -isystem /tmp/tflitebuild/ml_dtypes/src/ml_dtypes/ml_dtypes -isystem /tmp/tflitebuild/ruy/include -isystem /tmp/tflitebuild/cpuinfo/include -isystem /tmp/tflitebuild/ARM_NEON_2_x86_SSE/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -DEIGEN_NEON_GEBP_NR=4 -DTFL_STATIC_LIBRARY_BUILD -std=c++17 -MD -MT lib/Analysis/CMakeFiles/LLVMAnalysis.dir/DevelopmentModeInlineAdvisor.cpp.o -MF lib/Analysis/CMakeFiles/LLVMAnalysis.dir/DevelopmentModeInlineAdvisor.cpp.o.d -o lib/Analysis/CMakeFiles/LLVMAnalysis.dir/DevelopmentModeInlineAdvisor.cpp.o -c /b/ml-opt-devrel-x86-64-b1/llvm-project/llvm/lib/Analysis/DevelopmentModeInlineAdvisor.cpp
/b/ml-opt-devrel-x86-64-b1/llvm-project/llvm/lib/Analysis/DevelopmentModeInlineAdvisor.cpp:284:30: error: use of undeclared identifier 'getFeatureMap'
  284 |   std::vector<TensorSpec> FT(getFeatureMap().begin(), getFeatureMap().end());
      |                              ^
/b/ml-opt-devrel-x86-64-b1/llvm-project/llvm/lib/Analysis/DevelopmentModeInlineAdvisor.cpp:284:55: error: use of undeclared identifier 'getFeatureMap'
  284 |   std::vector<TensorSpec> FT(getFeatureMap().begin(), getFeatureMap().end());
      |                                                       ^
/b/ml-opt-devrel-x86-64-b1/llvm-project/llvm/lib/Analysis/DevelopmentModeInlineAdvisor.cpp:310:27: error: use of undeclared identifier 'getFeatureMap'
  310 |   size_t FeatureMapSize = getFeatureMap().size();
      |                           ^
/b/ml-opt-devrel-x86-64-b1/llvm-project/llvm/lib/Analysis/DevelopmentModeInlineAdvisor.cpp:110:34: warning: private field 'FeatureMap' is not used [-Wunused-private-field]
  110 |   const std::vector<TensorSpec> &FeatureMap;
      |                                  ^
1 warning and 3 errors generated.
70.214 [1537/47/2359] Building AMDGPUGenCallingConv.inc...
71.449 [1537/46/2360] Building CXX object lib/Transforms/Scalar/CMakeFiles/LLVMScalarOpts.dir/CallSiteSplitting.cpp.o
71.956 [1537/45/2361] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/LoopRotationUtils.cpp.o
72.224 [1537/44/2362] Building CXX object lib/Transforms/Scalar/CMakeFiles/LLVMScalarOpts.dir/PlaceSafepoints.cpp.o
72.403 [1537/43/2363] Building RISCVGenInstrInfo.inc...
72.426 [1537/42/2364] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/LoopConstrainer.cpp.o
73.340 [1537/41/2365] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/LoopVersioning.cpp.o
73.493 [1537/40/2366] Building CXX object lib/Transforms/IPO/CMakeFiles/LLVMipo.dir/ModuleInliner.cpp.o
73.558 [1537/39/2367] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/LoopUnrollRuntime.cpp.o
73.757 [1537/38/2368] Building CXX object lib/Transforms/Scalar/CMakeFiles/LLVMScalarOpts.dir/LoopBoundSplit.cpp.o
73.809 [1537/37/2369] Building CXX object lib/Transforms/IPO/CMakeFiles/LLVMipo.dir/SCCP.cpp.o
73.987 [1537/36/2370] Building CXX object lib/Transforms/Scalar/CMakeFiles/LLVMScalarOpts.dir/InductiveRangeCheckElimination.cpp.o
74.018 [1537/35/2371] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/CloneFunction.cpp.o
74.150 [1537/34/2372] Building AMDGPUGenAsmWriter.inc...
75.087 [1537/33/2373] Building RISCVGenGlobalISel.inc...
75.232 [1537/32/2374] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/InlineOrder.cpp.o
75.857 [1537/31/2375] Building CXX object lib/Transforms/Scalar/CMakeFiles/LLVMScalarOpts.dir/LoopDistribute.cpp.o
76.420 [1537/30/2376] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/InlineAdvisor.cpp.o
76.915 [1537/29/2377] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/LoopPeel.cpp.o
76.952 [1537/28/2378] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/LoopUnrollAndJam.cpp.o
76.991 [1537/27/2379] Building CXX object lib/Transforms/IPO/CMakeFiles/LLVMipo.dir/FunctionSpecialization.cpp.o
77.035 [1537/26/2380] Building CXX object lib/Transforms/IPO/CMakeFiles/LLVMipo.dir/Inliner.cpp.o
77.756 [1537/25/2381] Building CXX object lib/Transforms/IPO/CMakeFiles/LLVMipo.dir/ThinLTOBitcodeWriter.cpp.o
77.870 [1537/24/2382] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/LoopUnroll.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/156120