[llvm] [Offload][NFC] Use tablegen names rather than `name` parameter for API (PR #154736)

Michał Górny via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 29 07:43:09 PDT 2025


mgorny wrote:

This seems to be causing a bunch of test failures for me:

```
FAIL: libomptarget :: aarch64-unknown-linux-gnu :: tools/offload-tblgen/functions_ranged_param.td (289 of 746)
******************** TEST 'libomptarget :: aarch64-unknown-linux-gnu :: tools/offload-tblgen/functions_ranged_param.td' FAILED ********************
Exit Code: 2

Command Output (stdout):
--
# RUN: at line 1
/var/tmp/portage/llvm-runtimes/offload-22.0.0.9999/work/offload_build/offload-tblgen -gen-print-header -I /var/tmp/portage/llvm-runtimes/offload-22.0.0.9999/work/offload/test/tools/offload-tblgen/../../../liboffload/API /var/tmp/portage/llvm-runtimes/offload-22.0.0.9999/work/offload/test/tools/offload-tblgen/functions_ranged_param.td | /usr/lib/llvm/22/bin/FileCheck /var/tmp/portage/llvm-runtimes/offload-22.0.0.9999/work/offload/test/tools/offload-tblgen/functions_ranged_param.td
# executed command: /var/tmp/portage/llvm-runtimes/offload-22.0.0.9999/work/offload_build/offload-tblgen -gen-print-header -I /var/tmp/portage/llvm-runtimes/offload-22.0.0.9999/work/offload/test/tools/offload-tblgen/../../../liboffload/API /var/tmp/portage/llvm-runtimes/offload-22.0.0.9999/work/offload/test/tools/offload-tblgen/functions_ranged_param.td
# .---command stderr------------
# | /var/tmp/portage/llvm-runtimes/offload-22.0.0.9999/work/offload/test/tools/offload-tblgen/functions_ranged_param.td:12:9: error: Value 'name' unknown!
# |     let name = "some_handle_t";
# |         ^
# `-----------------------------
# error: command failed with exit status: 1
# executed command: /usr/lib/llvm/22/bin/FileCheck /var/tmp/portage/llvm-runtimes/offload-22.0.0.9999/work/offload/test/tools/offload-tblgen/functions_ranged_param.td
# .---command stderr------------
# | FileCheck error: '<stdin>' is empty.
# | FileCheck command line:  /usr/lib/llvm/22/bin/FileCheck /var/tmp/portage/llvm-runtimes/offload-22.0.0.9999/work/offload/test/tools/offload-tblgen/functions_ranged_param.td
# `-----------------------------
# error: command failed with exit status: 2

--

********************
FAIL: libomptarget :: aarch64-unknown-linux-gnu :: tools/offload-tblgen/default_returns.td (290 of 746)
******************** TEST 'libomptarget :: aarch64-unknown-linux-gnu :: tools/offload-tblgen/default_returns.td' FAILED ********************
Exit Code: 2

Command Output (stdout):
--
# RUN: at line 1
/var/tmp/portage/llvm-runtimes/offload-22.0.0.9999/work/offload_build/offload-tblgen -gen-api -I /var/tmp/portage/llvm-runtimes/offload-22.0.0.9999/work/offload/test/tools/offload-tblgen/../../../liboffload/API /var/tmp/portage/llvm-runtimes/offload-22.0.0.9999/work/offload/test/tools/offload-tblgen/default_returns.td | /usr/lib/llvm/22/bin/FileCheck /var/tmp/portage/llvm-runtimes/offload-22.0.0.9999/work/offload/test/tools/offload-tblgen/default_returns.td --check-prefix=CHECK-API
# executed command: /var/tmp/portage/llvm-runtimes/offload-22.0.0.9999/work/offload_build/offload-tblgen -gen-api -I /var/tmp/portage/llvm-runtimes/offload-22.0.0.9999/work/offload/test/tools/offload-tblgen/../../../liboffload/API /var/tmp/portage/llvm-runtimes/offload-22.0.0.9999/work/offload/test/tools/offload-tblgen/default_returns.td
# .---command stderr------------
# | /var/tmp/portage/llvm-runtimes/offload-22.0.0.9999/work/offload/test/tools/offload-tblgen/default_returns.td:10:9: error: Value 'name' unknown!
# |     let name = "ol_foo_handle_t";
# |         ^
# `-----------------------------
# error: command failed with exit status: 1
# executed command: /usr/lib/llvm/22/bin/FileCheck /var/tmp/portage/llvm-runtimes/offload-22.0.0.9999/work/offload/test/tools/offload-tblgen/default_returns.td --check-prefix=CHECK-API
# .---command stderr------------
# | FileCheck error: '<stdin>' is empty.
# | FileCheck command line:  /usr/lib/llvm/22/bin/FileCheck /var/tmp/portage/llvm-runtimes/offload-22.0.0.9999/work/offload/test/tools/offload-tblgen/default_returns.td --check-prefix=CHECK-API
# `-----------------------------
# error: command failed with exit status: 2

--

********************
```

and so on:

```
Failed Tests (16):
  libomptarget :: aarch64-unknown-linux-gnu :: tools/offload-tblgen/default_returns.td
  libomptarget :: aarch64-unknown-linux-gnu :: tools/offload-tblgen/entry_points.td
  libomptarget :: aarch64-unknown-linux-gnu :: tools/offload-tblgen/functions_basic.td
  libomptarget :: aarch64-unknown-linux-gnu :: tools/offload-tblgen/functions_code_loc.td
  libomptarget :: aarch64-unknown-linux-gnu :: tools/offload-tblgen/functions_ranged_param.td
  libomptarget :: aarch64-unknown-linux-gnu :: tools/offload-tblgen/print_enum.td
  libomptarget :: aarch64-unknown-linux-gnu :: tools/offload-tblgen/print_function.td
  libomptarget :: aarch64-unknown-linux-gnu :: tools/offload-tblgen/type_tagged_enum.td
  libomptarget :: aarch64-unknown-linux-gnu-LTO :: tools/offload-tblgen/default_returns.td
  libomptarget :: aarch64-unknown-linux-gnu-LTO :: tools/offload-tblgen/entry_points.td
  libomptarget :: aarch64-unknown-linux-gnu-LTO :: tools/offload-tblgen/functions_basic.td
  libomptarget :: aarch64-unknown-linux-gnu-LTO :: tools/offload-tblgen/functions_code_loc.td
  libomptarget :: aarch64-unknown-linux-gnu-LTO :: tools/offload-tblgen/functions_ranged_param.td
  libomptarget :: aarch64-unknown-linux-gnu-LTO :: tools/offload-tblgen/print_enum.td
  libomptarget :: aarch64-unknown-linux-gnu-LTO :: tools/offload-tblgen/print_function.td
  libomptarget :: aarch64-unknown-linux-gnu-LTO :: tools/offload-tblgen/type_tagged_enum.td
```

Don't tests need to be updated after this change?

https://github.com/llvm/llvm-project/pull/154736


More information about the llvm-commits mailing list