[llvm] 072a003 - [ADT] Avoid creating iterators in DenseMap::operator[] (NFC) (#155862)

[via llvm-commits]

Author: Benjamin Maxwell
Date: 2025-08-29T09:51:10+01:00
New Revision: 072a003235b35f4fdd60a7db9e50af8da63a6bae

URL: https://github.com/llvm/llvm-project/commit/072a003235b35f4fdd60a7db9e50af8da63a6bae
DIFF: https://github.com/llvm/llvm-project/commit/072a003235b35f4fdd60a7db9e50af8da63a6bae.diff

LOG: [ADT] Avoid creating iterators in DenseMap::operator[] (NFC) (#155862)

An attempt to resolve the slowdown from #155204

Added: 
    

Modified: 
    llvm/include/llvm/ADT/DenseMap.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/ADT/DenseMap.h b/llvm/include/llvm/ADT/DenseMap.h
index c44706a597fa6..afd87b492ed61 100644
--- a/llvm/include/llvm/ADT/DenseMap.h
+++ b/llvm/include/llvm/ADT/DenseMap.h
@@ -348,11 +348,11 @@ class DenseMapBase : public DebugEpochBase {
   }
 
   ValueT &operator[](const KeyT &Key) {
-    return try_emplace_impl(Key).first->second;
+    return lookupOrInsertIntoBucket(Key).first->second;
   }
 
   ValueT &operator[](KeyT &&Key) {
-    return try_emplace_impl(std::move(Key)).first->second;
+    return lookupOrInsertIntoBucket(std::move(Key)).first->second;
   }
 
   /// isPointerIntoBucketsArray - Return true if the specified pointer points
@@ -477,16 +477,24 @@ class DenseMapBase : public DebugEpochBase {
 
 private:
   template <typename KeyArgT, typename... Ts>
-  std::pair<iterator, bool> try_emplace_impl(KeyArgT &&Key, Ts &&...Args) {
+  std::pair<BucketT *, bool> lookupOrInsertIntoBucket(KeyArgT &&Key,
+                                                      Ts &&...Args) {
     BucketT *TheBucket = nullptr;
     if (LookupBucketFor(Key, TheBucket))
-      return {makeInsertIterator(TheBucket), false}; // Already in the map.
+      return {TheBucket, false}; // Already in the map.
 
     // Otherwise, insert the new element.
     TheBucket = findBucketForInsertion(Key, TheBucket);
     TheBucket->getFirst() = std::forward<KeyArgT>(Key);
     ::new (&TheBucket->getSecond()) ValueT(std::forward<Ts>(Args)...);
-    return {makeInsertIterator(TheBucket), true};
+    return {TheBucket, true};
+  }
+
+  template <typename KeyArgT, typename... Ts>
+  std::pair<iterator, bool> try_emplace_impl(KeyArgT &&Key, Ts &&...Args) {
+    auto [Bucket, Inserted] = lookupOrInsertIntoBucket(
+        std::forward<KeyArgT>(Key), std::forward<Ts>(Args)...);
+    return {makeInsertIterator(Bucket), Inserted};
   }
 
   iterator makeIterator(BucketT *P, BucketT *E, DebugEpochBase &Epoch,