[llvm] [CMake] Remove LLVM_ENABLE_IR_PGO Option (PR #155958)
Aiden Grossman via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 28 18:57:19 PDT 2025
https://github.com/boomanaiden154 created https://github.com/llvm/llvm-project/pull/155958
It has been deprecated for eight years now
(a702fa17f31abd5efce302ef3d4cf2fbaf167368), and all users that I know of are using LLVM_BUILD_INSTRUMENTED.
>From 46bdced2b5629aac2b95532a1150febdf47653cc Mon Sep 17 00:00:00 2001
From: Aiden Grossman <aidengrossman at google.com>
Date: Fri, 29 Aug 2025 01:55:39 +0000
Subject: [PATCH] [CMake] Remove LLVM_ENABLE_IR_PGO Option
It has been deprecated for eight years now
(a702fa17f31abd5efce302ef3d4cf2fbaf167368), and all users that I know of
are using LLVM_BUILD_INSTRUMENTED.
---
llvm/cmake/modules/HandleLLVMOptions.cmake | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/llvm/cmake/modules/HandleLLVMOptions.cmake b/llvm/cmake/modules/HandleLLVMOptions.cmake
index d3c6e9f6a168c..ce7464ea1ca2b 100644
--- a/llvm/cmake/modules/HandleLLVMOptions.cmake
+++ b/llvm/cmake/modules/HandleLLVMOptions.cmake
@@ -1172,16 +1172,13 @@ if(LLVM_ENABLE_EH AND NOT LLVM_ENABLE_RTTI)
message(FATAL_ERROR "Exception handling requires RTTI. You must set LLVM_ENABLE_RTTI to ON")
endif()
-option(LLVM_ENABLE_IR_PGO "Build LLVM and tools with IR PGO instrumentation (deprecated)" Off)
-mark_as_advanced(LLVM_ENABLE_IR_PGO)
-
set(LLVM_BUILD_INSTRUMENTED OFF CACHE STRING "Build LLVM and tools with PGO instrumentation. May be specified as IR or Frontend")
set(LLVM_VP_COUNTERS_PER_SITE "1.5" CACHE STRING "Value profile counters to use per site for IR PGO with Clang")
mark_as_advanced(LLVM_BUILD_INSTRUMENTED LLVM_VP_COUNTERS_PER_SITE)
string(TOUPPER "${LLVM_BUILD_INSTRUMENTED}" uppercase_LLVM_BUILD_INSTRUMENTED)
if (LLVM_BUILD_INSTRUMENTED)
- if (LLVM_ENABLE_IR_PGO OR uppercase_LLVM_BUILD_INSTRUMENTED STREQUAL "IR")
+ if (uppercase_LLVM_BUILD_INSTRUMENTED STREQUAL "IR")
append("-fprofile-generate=\"${LLVM_PROFILE_DATA_DIR}\""
CMAKE_CXX_FLAGS
CMAKE_C_FLAGS)
More information about the llvm-commits
mailing list