[llvm] [lit] Use `.format()` over format strings literals (PR #155912)

Justin Fargnoli via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 28 13:08:10 PDT 2025


https://github.com/justinfargnoli updated https://github.com/llvm/llvm-project/pull/155912

>From f6f1f6e88d305acf84356c94d8ea203d334986c0 Mon Sep 17 00:00:00 2001
From: Justin Fargnoli <jfargnoli at nvidia.com>
Date: Thu, 28 Aug 2025 20:02:54 +0000
Subject: [PATCH 1/2] [lit] Use .format over format strings

---
 llvm/test/lit.cfg.py | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/llvm/test/lit.cfg.py b/llvm/test/lit.cfg.py
index b23922d01483a..4a5d251f9a411 100644
--- a/llvm/test/lit.cfg.py
+++ b/llvm/test/lit.cfg.py
@@ -321,7 +321,7 @@ def ptxas_supported_isa_versions(ptxas, major_version, minor_version):
     if supported_isa_versions:
         return supported_isa_versions
     if major_version >= 13:
-        raise RuntimeError(f"ptxas {ptxas} does not support ISA version listing")
+        raise RuntimeError("ptxas {} does not support ISA version listing".format(ptxas))
 
     cuda_version_to_isa_version = {
         (12, 9): [(8, 8)],
@@ -404,7 +404,7 @@ def ptxas_supports_address_size_32(ptxas_executable):
         return False
     if "Missing .version directive at start of file" in result.stderr:
         return True
-    raise RuntimeError(f"Unexpected ptxas output: {result.stderr}")
+    raise RuntimeError("Unexpected ptxas output: {}".format(result.stderr))
 
 
 def enable_ptxas(ptxas_executable):
@@ -412,20 +412,20 @@ def enable_ptxas(ptxas_executable):
     tools.extend(
         [
             ToolSubst("%ptxas", ptxas_executable),
-            ToolSubst("%ptxas-verify", f"{ptxas_executable} -c -"),
+            ToolSubst("%ptxas-verify", "{} -c -".format(ptxas_executable)),
         ]
     )
 
     major_version, minor_version = ptxas_version(ptxas_executable)
-    config.available_features.add(f"ptxas-{major_version}.{minor_version}")
+    config.available_features.add("ptxas-{}.{}".format(major_version, minor_version))
 
     for major, minor in ptxas_supported_isa_versions(
         ptxas_executable, major_version, minor_version
     ):
-        config.available_features.add(f"ptxas-isa-{major}.{minor}")
+        config.available_features.add("ptxas-isa-{}.{}".format(major, minor))
 
     for sm in ptxas_supported_sms(ptxas_executable):
-        config.available_features.add(f"ptxas-sm_{sm}")
+        config.available_features.add("ptxas-sm_{}".format(sm))
 
     if ptxas_supports_address_size_32(ptxas_executable):
         config.available_features.add("ptxas-ptr32")

>From 387898ce7cad495c5ccf669355032b8ecf458744 Mon Sep 17 00:00:00 2001
From: Justin Fargnoli <jfargnoli at nvidia.com>
Date: Thu, 28 Aug 2025 20:08:00 +0000
Subject: [PATCH 2/2] Format

---
 llvm/test/lit.cfg.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/llvm/test/lit.cfg.py b/llvm/test/lit.cfg.py
index 4a5d251f9a411..eaafaa31ace46 100644
--- a/llvm/test/lit.cfg.py
+++ b/llvm/test/lit.cfg.py
@@ -321,7 +321,9 @@ def ptxas_supported_isa_versions(ptxas, major_version, minor_version):
     if supported_isa_versions:
         return supported_isa_versions
     if major_version >= 13:
-        raise RuntimeError("ptxas {} does not support ISA version listing".format(ptxas))
+        raise RuntimeError(
+            "ptxas {} does not support ISA version listing".format(ptxas)
+        )
 
     cuda_version_to_isa_version = {
         (12, 9): [(8, 8)],



More information about the llvm-commits mailing list