[llvm] Revert "[ADT] Fix signed integer overflow" (PR #155875)

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 28 09:06:33 PDT 2025


https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/155875

Reverts llvm/llvm-project#155826

To simplify revert of https://github.com/llvm/llvm-project/pull/155549 which introduces UBs.

>From d1b007163d0e6e6d7aad0f7b7447c2eeb183ade2 Mon Sep 17 00:00:00 2001
From: Vitaly Buka <vitalybuka at gmail.com>
Date: Thu, 28 Aug 2025 09:05:44 -0700
Subject: [PATCH] Revert "[ADT] Fix signed integer overflow (#155826)"

This reverts commit a01933d586343b7006bf354dc6557ba65621072e.
---
 llvm/include/llvm/ADT/DenseMapInfo.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/llvm/include/llvm/ADT/DenseMapInfo.h b/llvm/include/llvm/ADT/DenseMapInfo.h
index ec7a116856bb4..930bd4baca31d 100644
--- a/llvm/include/llvm/ADT/DenseMapInfo.h
+++ b/llvm/include/llvm/ADT/DenseMapInfo.h
@@ -124,8 +124,7 @@ struct DenseMapInfo<
     if constexpr (std::is_unsigned_v<T> && sizeof(T) > sizeof(unsigned))
       return densemap::detail::mix(Val);
     else
-      return static_cast<unsigned>(Val *
-                                   static_cast<std::make_unsigned_t<T>>(37U));
+      return static_cast<unsigned>(Val * 37U);
   }
 
   static bool isEqual(const T &LHS, const T &RHS) { return LHS == RHS; }



More information about the llvm-commits mailing list