[llvm] [DirectX] Don't byte-swap returned byte-offset (PR #155860)

via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 28 08:48:06 PDT 2025


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-backend-directx

Author: Finn Plummer (inbelic)

<details>
<summary>Changes</summary>

- The returned byte offset from `rewriteOffsetToCurrentByte` should not be byte-swapped as it will be compared and interpreted as a uint32_t in its uses

This commit corrects build failures that hit an assert on big-endian builds

---
Full diff: https://github.com/llvm/llvm-project/pull/155860.diff


1 Files Affected:

- (modified) llvm/lib/MC/DXContainerRootSignature.cpp (+3-2) 


``````````diff
diff --git a/llvm/lib/MC/DXContainerRootSignature.cpp b/llvm/lib/MC/DXContainerRootSignature.cpp
index 3513892ffcdcc..4d5322b5b3cbe 100644
--- a/llvm/lib/MC/DXContainerRootSignature.cpp
+++ b/llvm/lib/MC/DXContainerRootSignature.cpp
@@ -22,11 +22,12 @@ static uint32_t writePlaceholder(raw_svector_ostream &Stream) {
 
 static uint32_t rewriteOffsetToCurrentByte(raw_svector_ostream &Stream,
                                            uint32_t Offset) {
+  uint32_t ByteOffset = Stream.tell();
   uint32_t Value =
       support::endian::byte_swap<uint32_t, llvm::endianness::little>(
-          Stream.tell());
+          ByteOffset);
   Stream.pwrite(reinterpret_cast<const char *>(&Value), sizeof(Value), Offset);
-  return Value;
+  return ByteOffset;
 }
 
 size_t RootSignatureDesc::getSize() const {

``````````

</details>


https://github.com/llvm/llvm-project/pull/155860


More information about the llvm-commits mailing list