[llvm] [Dexter] Update Dexter lit substitutions, making lldb-dap the default (PR #155838)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 28 07:11:50 PDT 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {darker}-->
:warning: Python code formatter, darker found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
darker --check --diff -r origin/main...HEAD cross-project-tests/lit.cfg.py
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from darker here.
</summary>
``````````diff
--- lit.cfg.py 2025-08-28 14:05:50.000000 +0000
+++ lit.cfg.py 2025-08-28 14:11:22.829348 +0000
@@ -124,13 +124,22 @@
dexter_path = os.path.join(
config.cross_project_tests_src_root, "debuginfo-tests", "dexter", "dexter.py"
)
tools.append(ToolSubst("%dexter", f'"{sys.executable}" "{dexter_path}" test'))
if lldb_dap_path is not None:
- tools.append(ToolSubst("%dexter_lldb_args", f'--lldb-executable "{lldb_dap_path}" --debugger lldb-dap'))
+ tools.append(
+ ToolSubst(
+ "%dexter_lldb_args",
+ f'--lldb-executable "{lldb_dap_path}" --debugger lldb-dap',
+ )
+ )
elif lldb_path is not None:
- tools.append(ToolSubst("%dexter_lldb_args", f'--lldb-executable "{lldb_path}" --debugger lldb'))
+ tools.append(
+ ToolSubst(
+ "%dexter_lldb_args", f'--lldb-executable "{lldb_path}" --debugger lldb'
+ )
+ )
# For testing other bits of dexter that aren't under the "test" subcommand,
# have a %dexter_base substitution.
dexter_base_cmd = '"{}" "{}"'.format(sys.executable, dexter_path)
tools.append(ToolSubst("%dexter_base", dexter_base_cmd))
@@ -152,19 +161,24 @@
dependencies = ["clang", "lldb"]
dexter_regression_test_c_builder = "clang"
dexter_regression_test_cxx_builder = "clang++"
if lldb_dap_path is not None:
dexter_regression_test_debugger = "lldb-dap"
- dexter_regression_test_additional_flags = f'--lldb-executable "{lldb_dap_path}"'
+ dexter_regression_test_additional_flags = (
+ f'--lldb-executable "{lldb_dap_path}"'
+ )
else:
dexter_regression_test_debugger = "lldb"
dexter_regression_test_additional_flags = f'--lldb-executable "{lldb_path}"'
dexter_regression_test_c_flags = "-O0 -glldb -std=gnu11"
dexter_regression_test_cxx_flags = "-O0 -glldb -std=gnu++11"
tools.append(
- ToolSubst("%dexter_regression_test_debugger_args", f"--debugger {dexter_regression_test_debugger} {dexter_regression_test_additional_flags}")
+ ToolSubst(
+ "%dexter_regression_test_debugger_args",
+ f"--debugger {dexter_regression_test_debugger} {dexter_regression_test_additional_flags}",
+ )
)
# Typical command would take the form:
# ./path_to_py/python.exe ./path_to_dex/dexter.py test --fail-lt 1.0 -w --binary %t --debugger lldb --cflags '-O0 -g'
dexter_regression_test_run = " ".join(
``````````
</details>
https://github.com/llvm/llvm-project/pull/155838
More information about the llvm-commits
mailing list