[llvm] [Github] Fix revisions in code format action reproducers (PR #155193)
Aiden Grossman via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 26 15:27:08 PDT 2025
================
@@ -175,9 +181,32 @@ class ClangFormatHelper(FormatHelper):
name = "clang-format"
friendly_name = "C/C++ code formatter"
+ def _construct_command(self, diff_expression: list[str] | None):
----------------
boomanaiden154 wrote:
Yeah, it's a bit weird and I'm not sure why the script special cases that. But this is just mirroring the existing code.
I remember some things like this being done for a reason though (maybe local testing or something, or for an earlier version of the script) and I don't want to remove things until I've done the git sleuthing and understand what's going on.
Either way, I think it's perfectly reasonable to leave for a follow up patch.
https://github.com/llvm/llvm-project/pull/155193
More information about the llvm-commits
mailing list