[llvm] [LLVM][MC] Add support to cull inactive decoders in decoder emitter (PR #154865)
Sergei Barannikov via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 26 10:21:50 PDT 2025
s-barannikov wrote:
Looks good to me overall.
One thing I'm not sure of is using std::bitset where a larger integer type would do (e.g., using std::bitset<48> instead of uint64_t). Probably not a big deal, but I thought it is worth pointing out.
Secondly, what will happen if I use a "wrong" type of instruction when calling decodeInstruction? Will it silently use the wrong decodeToMCInst? If so, this is not great, and it should be possible to add a runtime check that calling decodeInstruction with a particular table resolves to the correct decodeToMCInst.
https://github.com/llvm/llvm-project/pull/154865
More information about the llvm-commits
mailing list