[llvm] [Transforms] Allow non-regex Source in SymbolRewriter in case of using ExplicitRewriteDescriptor (PR #154319)

Dmitry Vasilyev via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 25 11:07:48 PDT 2025


slydiman wrote:

> This looks reasonable to me, but could you please add test coverage for all three cases being changed?

Done.
 
> (Or alternatively, we should do a preliminary refactoring to deduplicate this case -- at least at a cursory look, all three implementations are the same?)

I wouldn't refactor this code. This code assumes 3rd party extension. Even the description at the beginning contains recommendations `New rewrite descriptors can be created. Addding a new rewrite descriptor involves: ...` So refactoring can complicate private implementations.


https://github.com/llvm/llvm-project/pull/154319


More information about the llvm-commits mailing list