[clang] [llvm] Singleton hack of fixing static initialisation order fiasco (PR #154541)

Mircea Trofin via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 25 07:49:11 PDT 2025


================
@@ -126,7 +130,7 @@ const TensorSpec llvm::DefaultDecisionSpec =
     TensorSpec::createSpec<int64_t>(DefaultDecisionName, {1});
 const char *const llvm::RewardName = "delta_size";
 
-CallBase *getInlinableCS(Instruction &I) {
+static CallBase *getInlinableCS(Instruction &I) {
----------------
mtrofin wrote:

I'd separate the drive-by fix from the topic of this PR. You can do a follow-up "NFC" PR with just this. It adds an extra mental step for folks looking later at this change and trying to understand how this member static-ness relates to the topic of the PR.

https://github.com/llvm/llvm-project/pull/154541


More information about the llvm-commits mailing list