[llvm] [AMDGPU] Fix unittest sign-compare (PR #155235)

Robert Imschweiler via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 25 05:00:15 PDT 2025


https://github.com/ro-i created https://github.com/llvm/llvm-project/pull/155235

Apparently, some buildbots build unittests with `-Werror,-Wsign-compare`: https://lab.llvm.org/buildbot/#/builders/145/builds/9299

>From 2d4c7ca586577aa53ac8c7fedf6d5ec87751ff8d Mon Sep 17 00:00:00 2001
From: Robert Imschweiler <robert.imschweiler at amd.com>
Date: Mon, 25 Aug 2025 06:53:42 -0500
Subject: [PATCH] [AMDGPU] Fix unittest sign-compare

---
 llvm/unittests/Target/AMDGPU/AMDGPUUnitTests.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llvm/unittests/Target/AMDGPU/AMDGPUUnitTests.cpp b/llvm/unittests/Target/AMDGPU/AMDGPUUnitTests.cpp
index d01d808f988ba..593991c71d706 100644
--- a/llvm/unittests/Target/AMDGPU/AMDGPUUnitTests.cpp
+++ b/llvm/unittests/Target/AMDGPU/AMDGPUUnitTests.cpp
@@ -335,7 +335,7 @@ TEST(AMDGPU, TestGetNamedOperandIdx) {
       if (OpName == AMDGPU::OpName::NUM_OPERAND_NAMES)
         continue;
       int16_t RetrievedIdx = AMDGPU::getNamedOperandIdx(Opcode, OpName);
-      EXPECT_EQ(Idx, RetrievedIdx)
+      EXPECT_EQ(Idx, static_cast<unsigned>(RetrievedIdx))
           << "Opcode " << Opcode << " (" << MCII->getName(Opcode) << ')';
     }
   }



More information about the llvm-commits mailing list