[llvm] [AMDGPU][gfx1250] Implement SIMemoryLegalizer (PR #154726)

[Christudasan Devadasan via llvm-commits]

================
@@ -1656,6 +1656,11 @@ let OtherPredicates = [HasImageInsts] in {
   def S_WAIT_KMCNT_soft : SOPP_Pseudo <"s_soft_wait_kmcnt", (ins s16imm:$simm16), "$simm16">;
 }
 
+
+let SubtargetPredicate = HasWaitXcnt in {
----------------
cdevadas wrote:

> S_WAIT_XCNT

You're right. It is currently defined under let SubtargetPredicate = HasWaitXcnt. 
I would choose the OtherPredicates here. I will leave it up to you. 
People have been using these predicates interchangeably. But I wish we had a recommendation in place.

https://github.com/llvm/llvm-project/pull/154726