[llvm] [llvm-readobj][COFF] Implement --coff-pseudoreloc in llvm-readobj to dump runtime pseudo-relocation records (PR #151816)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 11 01:15:03 PDT 2025


================
@@ -2101,12 +2124,11 @@ void COFFDumper::printCOFFPseudoReloc() {
   };
   const PseudoRelocationHeader HeaderV2(1);
   if (RawRelocs.size() < sizeof(HeaderV2) ||
-      (memcmp(RawRelocs.data(), &HeaderV2, sizeof(HeaderV2)) != 0)) {
-    reportWarning(
+      (memcmp(RawRelocs.data(), &HeaderV2, sizeof(HeaderV2)) != 0))
+    return reportWarning(
----------------
jh7370 wrote:

I'm not sure this is normal style - you're returning a `void`, which would normally be a distinct `return;` statement.

https://github.com/llvm/llvm-project/pull/151816


More information about the llvm-commits mailing list