[llvm] [Analysis] Remove an unreachable check. NFC. (PR #152874)

Yingwei Zheng via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 9 10:58:31 PDT 2025


https://github.com/dtcxzyw created https://github.com/llvm/llvm-project/pull/152874

Binops never produce pointer values.

>From 37e80908656593df53fcaca62a4e759646505328 Mon Sep 17 00:00:00 2001
From: Yingwei Zheng <dtcxzyw2333 at gmail.com>
Date: Sun, 10 Aug 2025 01:56:46 +0800
Subject: [PATCH] [Analysis] Remove an unreachable check. NFC.

---
 llvm/lib/Analysis/Loads.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/llvm/lib/Analysis/Loads.cpp b/llvm/lib/Analysis/Loads.cpp
index 78d0887d5d87e..9a2c9ba63ec7e 100644
--- a/llvm/lib/Analysis/Loads.cpp
+++ b/llvm/lib/Analysis/Loads.cpp
@@ -276,8 +276,7 @@ static bool AreEquivalentAddressValues(const Value *A, const Value *B) {
   // this function is only used when one address use dominates the
   // other, which means that they'll always either have the same
   // value or one of them will have an undefined value.
-  if (isa<BinaryOperator>(A) || isa<CastInst>(A) || isa<PHINode>(A) ||
-      isa<GetElementPtrInst>(A))
+  if (isa<CastInst>(A) || isa<PHINode>(A) || isa<GetElementPtrInst>(A))
     if (const Instruction *BI = dyn_cast<Instruction>(B))
       if (cast<Instruction>(A)->isIdenticalToWhenDefined(BI))
         return true;



More information about the llvm-commits mailing list