[llvm] [DependenceAnalysis] Extending SIV to handle fusable loops (PR #128782)
via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 8 12:15:13 PDT 2025
amehsan wrote:
> My concerns are:
>
> * Are such changes of the results always improvements?
> * Is it sound for passes other than LoopFuse to use such improved results?
>
About (1) I think forcing `isConsistent` is incorrect. It should be what the algorithm sets it to.
About (2) I believe this is fine. The user of `DA` (by which I mean the programmer who writes code) should understand what the input and outputs mean. IIRC, the question of whether two statements from two different loops are dependent or not is not relevant to any existing DA client other than loop fusion. If it is relevant to another pass, then same concerns that you bring up is applicable to the results that `DA` produces today.
https://github.com/llvm/llvm-project/pull/128782
More information about the llvm-commits
mailing list