[llvm] [PowerPC] support branch hint for AtomicExpandImpl::expandAtomicCmpXchg (PR #152366)

[via llvm-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {undef deprecator}-->


:warning: undef deprecator found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git diff -U0 --pickaxe-regex -S '([^a-zA-Z0-9#_-]undef[^a-zA-Z0-9_-]|UndefValue::get)' 'HEAD~1' HEAD llvm/lib/CodeGen/AtomicExpandPass.cpp llvm/test/CodeGen/AArch64/GlobalISel/arm64-atomic.ll llvm/test/CodeGen/AArch64/GlobalISel/arm64-pcsections.ll llvm/test/CodeGen/AArch64/atomic-ops-msvc.ll llvm/test/CodeGen/AArch64/atomic-ops.ll llvm/test/CodeGen/AArch64/atomicrmw-fadd.ll llvm/test/CodeGen/AArch64/atomicrmw-fmax.ll llvm/test/CodeGen/AArch64/atomicrmw-fmin.ll llvm/test/CodeGen/AArch64/atomicrmw-fsub.ll llvm/test/CodeGen/AArch64/cmpxchg-idioms.ll llvm/test/CodeGen/ARM/atomic-cmpxchg.ll llvm/test/CodeGen/ARM/cmpxchg-idioms.ll llvm/test/CodeGen/ARM/cmpxchg-weak.ll llvm/test/CodeGen/Hexagon/atomic-opaque-basic.ll llvm/test/CodeGen/PowerPC/PR35812-neg-cmpxchg.ll llvm/test/CodeGen/PowerPC/all-atomics.ll llvm/test/CodeGen/PowerPC/atomic-compare-exchange-weak.ll llvm/test/CodeGen/PowerPC/atomic-float.ll llvm/test/CodeGen/PowerPC/atomicrmw-cond-sub-clamp.ll llvm/test/CodeGen/PowerPC/atomicrmw-uinc-udec-wrap.ll llvm/test/CodeGen/PowerPC/atomics-regression.ll llvm/test/CodeGen/PowerPC/atomics.ll llvm/test/CodeGen/PowerPC/loop-comment.ll llvm/test/Transforms/AtomicExpand/ARM/atomic-expansion-v7.ll llvm/test/Transforms/AtomicExpand/ARM/atomic-expansion-v8.ll llvm/test/Transforms/AtomicExpand/ARM/cmpxchg-weak.ll
``````````

</details>


The following files introduce new uses of undef:
 - llvm/test/CodeGen/AArch64/GlobalISel/arm64-pcsections.ll

[Undef](https://llvm.org/docs/LangRef.html#undefined-values) is now deprecated and should only be used in the rare cases where no replacement is possible. For example, a load of uninitialized memory yields `undef`. You should use `poison` values for placeholders instead.

In tests, avoid using `undef` and having tests that trigger undefined behavior. If you need an operand with some unimportant value, you can add a new argument to the function and use that instead.

For example, this is considered a bad practice:
```llvm
define void @fn() {
  ...
  br i1 undef, ...
}
```

Please use the following instead:
```llvm
define void @fn(i1 %cond) {
  ...
  br i1 %cond, ...
}
```

Please refer to the [Undefined Behavior Manual](https://llvm.org/docs/UndefinedBehavior.html) for more information.



https://github.com/llvm/llvm-project/pull/152366