[llvm] Revert "Update .git-blame-ignore-revs for Pack/Unpack move (#152469)" (PR #152661)

Andrzej Warzyński via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 8 01:16:43 PDT 2025


https://github.com/banach-space created https://github.com/llvm/llvm-project/pull/152661

This reverts commit c43c1c0c45fc1ec3fab7abd6e19b318f6468bf28.

Apologies for the noise — I misunderstood how `git blame --ignore-rev`
works. It’s not suitable for large code-move changes and ends up making
`git blame` more confusing rather than cleaner. From the Git
documentation:

> Lines that were changed or added by an ignored commit will be blamed
> on the previous commit that changed that line or nearby lines.

In this case, since so many new lines were added, skipping the commit
causes `git blame` to attribute them to unrelated changes. I had
expected Git to preserve the true origin of the lines while skipping the
move itself — but that is not what happens.

Therefore, I’m reverting this change. Ignoring the commit obscures blame
history rather than improving it.


>From f06169b4268c7de94bfe6bcbc68766443778ecd9 Mon Sep 17 00:00:00 2001
From: Andrzej Warzynski <andrzej.warzynski at arm.com>
Date: Fri, 8 Aug 2025 09:06:36 +0100
Subject: [PATCH] Revert "Update .git-blame-ignore-revs for Pack/Unpack move
 (#152469)"
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This reverts commit c43c1c0c45fc1ec3fab7abd6e19b318f6468bf28.

Apologies for the noise — I misunderstood how `git blame --ignore-rev`
works. It’s not suitable for large code-move changes and ends up making
`git blame` more confusing rather than cleaner. From the Git
documentation:

> Lines that were changed or added by an ignored commit will be blamed
> on the previous commit that changed that line or nearby lines.

In this case, since so many new lines were added, skipping the commit
causes `git blame` to attribute them to unrelated changes. I had
expected Git to preserve the true origin of the lines while skipping the
move itself — but that is not what happens.

Therefore, I’m reverting this change. Ignoring the commit obscures blame
history rather than improving it.
---
 .git-blame-ignore-revs | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/.git-blame-ignore-revs b/.git-blame-ignore-revs
index 5c21c25da82ca..ea789ab5273a6 100644
--- a/.git-blame-ignore-revs
+++ b/.git-blame-ignore-revs
@@ -143,6 +143,3 @@ a3a007ad5fa20abc90ead4e1030b481bf109b4cf
 b7e332d3f59f567b1999fbcc660d7837cba8e406
 6056f942abe83b05406df8b04e95ec37a3d160b5
 906295b8a31c8dac5aa845864c0bca9f02f86184
-
-# [mlir][tensor][linalg] Move Pack/UnPack Ops to Linalg
-517800e37e8d3a4ee84214bef65e227612c2a98b



More information about the llvm-commits mailing list