[llvm] [HLSL][NFC] Fix range check in verifyRegisterSpace (PR #152615)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 7 17:00:01 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-hlsl
Author: Shafik Yaghmour (shafik)
<details>
<summary>Changes</summary>
Static analysis flagged the second part of this range check as always true. RegisterSpace is uint32_t therefore the max value is 0xFFFFFFFF and so the first check is sufficient.
---
Full diff: https://github.com/llvm/llvm-project/pull/152615.diff
1 Files Affected:
- (modified) llvm/lib/Frontend/HLSL/RootSignatureValidations.cpp (+1-1)
``````````diff
diff --git a/llvm/lib/Frontend/HLSL/RootSignatureValidations.cpp b/llvm/lib/Frontend/HLSL/RootSignatureValidations.cpp
index 9d84aa838f476..72308a3de5fd4 100644
--- a/llvm/lib/Frontend/HLSL/RootSignatureValidations.cpp
+++ b/llvm/lib/Frontend/HLSL/RootSignatureValidations.cpp
@@ -29,7 +29,7 @@ bool verifyRegisterValue(uint32_t RegisterValue) {
// This Range is reserverved, therefore invalid, according to the spec
// https://github.com/llvm/wg-hlsl/blob/main/proposals/0002-root-signature-in-clang.md#all-the-values-should-be-legal
bool verifyRegisterSpace(uint32_t RegisterSpace) {
- return !(RegisterSpace >= 0xFFFFFFF0 && RegisterSpace <= 0xFFFFFFFF);
+ return !(RegisterSpace >= 0xFFFFFFF0);
}
bool verifyRootDescriptorFlag(uint32_t Version, uint32_t FlagsVal) {
``````````
</details>
https://github.com/llvm/llvm-project/pull/152615
More information about the llvm-commits
mailing list