[llvm] [licm] clone metadata when hoisting conditional branch (PR #152232)

[Nikita Popov via llvm-commits]

================
@@ -857,9 +859,18 @@ class ControlFlowHoister {
     }
 
     // Now finally clone BI.
-    ReplaceInstWithInst(
-        HoistTarget->getTerminator(),
-        BranchInst::Create(HoistTrueDest, HoistFalseDest, BI->getCondition()));
+    auto *NewBI =
+        BranchInst::Create(HoistTrueDest, HoistFalseDest, BI->getCondition(),
+                           HoistTarget->getTerminator()->getIterator());
+    HoistTarget->getTerminator()->eraseFromParent();
+    // Copy all the metadata. In particular:
+    // - debug info (critical to Sample-based profiling) should be the same
+    // as the original branch, not that of HoistTarget->getTerminator(),
+    // which is what ReplaceInstWithInst would use.
----------------
nikic wrote:

Debug info usage of debuggers and SamplePGO is at odds here. Debuggers want this dropped, while SamplePGO does not. Our debug info policy is generally targeted towards debuggers.

https://github.com/llvm/llvm-project/pull/152232